Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-unnecessary-type-assertion] report more cases based on assignability#11789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

Conversation

@ulrichstark
Copy link
Contributor

PR Checklist

Overview

It now also reports cases like:

constv:number=5;constx=vasanyasnumber;

And fixes it to:

constv:number=5;constx=v;

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ulrichstark!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 24, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3aabb2b
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/69276d50ef2b5100089c69f1
😎 Deploy Previewhttps://deploy-preview-11789--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 24, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3aabb2b

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 17sView ↗
nx run-many -t lint✅ Succeeded3m 12sView ↗
nx run-many -t typecheck✅ Succeeded1m 55sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run types:build✅ Succeeded2sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-26 21:24:49 UTC

@codecov
Copy link

codecovbot commentedNov 24, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is93.40102% with13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.52%. Comparing base (3252978) to head (3aabb2b).

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts0.00%10 Missing⚠️
...-plugin/src/rules/explicit-member-accessibility.ts0.00%1 Missing⚠️
...es/eslint-plugin/src/rules/parameter-properties.ts0.00%1 Missing⚠️
...s/eslint-plugin/src/util/collectUnusedVariables.ts0.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #11789      +/-   ##==========================================+ Coverage   90.49%   90.52%   +0.03%==========================================  Files         522      522                Lines       53360    53485     +125       Branches     8911     8952      +41     ==========================================+ Hits        48286    48417     +131+ Misses       5059     5053       -6  Partials       15       15
FlagCoverage Δ
unittest90.52% <93.40%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts96.66% <100.00%> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts99.12% <100.00%> (ø)
...es/no-unnecessary-parameter-property-assignment.ts98.93% <100.00%> (ø)
...-plugin/src/rules/no-unnecessary-type-assertion.ts98.65% <100.00%> (+0.56%)⬆️
.../eslint-plugin/src/rules/triple-slash-reference.ts100.00% <100.00%> (ø)
...c/util/class-scope-analyzer/extractComputedName.ts71.64% <100.00%> (ø)
packages/rule-tester/src/RuleTester.ts73.90% <100.00%> (ø)
packages/typescript-estree/src/node-utils.ts70.27% <100.00%> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts99.05% <0.00%> (ø)
...es/eslint-plugin/src/rules/parameter-properties.ts98.42% <0.00%> (ø)
... and2 more
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ulrichstark
Copy link
ContributorAuthor

This was a pretty tricky change to get right. Coverage is at 100%, it reported multiple cases while dogfooding, I turned the false positives into test cases and fixed the true positives. Let the review iterations begin!

JoshuaKGoldberg reacted with rocket emoji

@ulrichstarkulrichstark marked this pull request as ready for reviewNovember 26, 2025 21:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule proposal: noas any when type is already expected type

1 participant

@ulrichstark
[8]ページ先頭
©2009-2025 Movatter.jp