typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore: check variable declaration syntax error against tsNode#11778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

fisker wants to merge6 commits intotypescript-eslint:main

base:main

Choose a base branch

fromfisker:variable-declare-check

Open

chore: check variable declaration syntax error against tsNode#11778

fisker wants to merge6 commits intotypescript-eslint:mainfromfisker:variable-declare-check

+102 −86

Conversation

Copy link

Contributor

fisker commentedNov 23, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Same as#11777

The syntax check should always check against TS node instead of ESTree node before convert, prepare for#11695

No logic changes, just refactor.

Note: this contains changes from#11777, but fixed bothVariableDeclaration,VariableDeclarationList, andVariableStatement.

If smaller changes are preferred, I'll rebase after#11777 gets merged.

fisker added5 commits

November 23, 2025 14:17

chore: checkVariableDeclaration syntax error against tsNode

0603fcb

RenamehasExclamationToken

ad1341f

FixVariableDeclarationList

50bd39f

Prepare for VariableStatement

fe1572f

FixVariableStatement

04fe79a

Copy link

Contributor

typescript-eslintbot commentedNov 23, 2025

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0cf79f9`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6927493f070cfd0008478e97
😎 Deploy Preview	https://deploy-preview-11778--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🔴 down 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedNov 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit0cf79f9

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 9s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 29s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 58s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	21s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	11s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-11-26 18:50:22 UTC

Copy link

codecovbot commentedNov 23, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is51.25000% with39 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.50%. Comparing base (c421d30) to head (0cf79f9).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	51.25%	39 Missing⚠️

❌ Your patch check has failed because the patch coverage (51.25%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11778      +/-   ##==========================================- Coverage   90.57%   90.50%   -0.07%==========================================  Files         522      522                Lines       53079    53365     +286       Branches     8842     8912      +70     ==========================================+ Hits        48074    48300     +226- Misses       4989     5051      +62+ Partials       16       14       -2

Flag	Coverage Δ
unittest	`90.50% <51.25%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/convert.ts	`31.29% <51.25%> (+0.21%)`	⬆️

... and14 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.