typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore: check`VariableDeclaration` syntax error against tsNode#11777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

fisker wants to merge1 commit intotypescript-eslint:main

base:main

Choose a base branch

fromfisker:VariableDeclaration-check

Open

chore: check`VariableDeclaration` syntax error against tsNode#11777

fisker wants to merge1 commit intotypescript-eslint:mainfromfisker:VariableDeclaration-check

+10 −11

Conversation

Copy link

Contributor

fisker commentedNov 23, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

The syntax check should always check against TS node instead of ESTree node before convert, prepare for#11695

VariableStatement check also checking against ESTree node, but it's quite complex, will give another try in seperate PR.

chore: checkVariableDeclaration syntax error against tsNode

0603fcb

Copy link

Contributor

typescript-eslintbot commentedNov 23, 2025

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0603fcb`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6922a7a6adbced0008fa169e
😎 Deploy Preview	https://deploy-preview-11777--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 5 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedNov 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit0603fcb

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 16s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 18s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 11s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	20s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	9s	View ↗
`nx run integration-tests:test`	✅ Succeeded	6s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-11-23 06:31:54 UTC

Copy link

codecovbot commentedNov 23, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is75.00000% with2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.57%. Comparing base (c421d30) to head (0603fcb).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	75.00%	2 Missing⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11777   +/-   ##=======================================  Coverage   90.57%   90.57%           =======================================  Files         522      522             Lines       53079    53076    -3       Branches     8842     8842           =======================================  Hits        48074    48074+ Misses       4989     4987    -2+ Partials       16       15    -1

Flag	Coverage Δ
unittest	`90.57% <75.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/convert.ts	`31.10% <75.00%> (+0.03%)`	⬆️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.