Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(typescript-estree): use class property to defineTSError.name instead ofObject.defineProperty()#11776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fisker
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3c3b68a
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/692294b5154e8800080ee4ed
😎 Deploy Previewhttps://deploy-preview-11776--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3c3b68a

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 9sView ↗
nx run-many -t lint✅ Succeeded3m 17sView ↗
nx run-many -t typecheck✅ Succeeded2m 6sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx run types:build✅ Succeeded6sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-23 05:12:53 UTC

@codecov
Copy link

codecovbot commentedNov 23, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (c421d30) to head (3c3b68a).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11776      +/-   ##==========================================- Coverage   90.57%   90.56%   -0.01%==========================================  Files         522      522                Lines       53079    53075       -4       Branches     8842     8842              ==========================================- Hits        48074    48070       -4  Misses       4989     4989                Partials       16       16
FlagCoverage Δ
unittest90.56% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/node-utils.ts70.26% <100.00%> (-0.22%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure, why not. It is a little unfortunate thatnew.target.name isn't available - but I think this is fine.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 24, 2025
@JoshuaKGoldbergJoshuaKGoldberg changed the titlechore: use class property to defineTSError.name instead ofObject.defineProperty()chore(typescript-estree): use class property to defineTSError.name instead ofObject.defineProperty()Nov 24, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitec8b652 intotypescript-eslint:mainDec 1, 2025
71 checks passed
@fiskerfisker deleted the TSError-name branchDecember 1, 2025 14:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp