Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: refactorcreateError for easier use#11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromfisker:createError
Nov 26, 2025

Conversation

@fisker
Copy link
Contributor

@fiskerfisker commentedNov 23, 2025
edited
Loading

PR Checklist

Overview

Move

letstart;
letend;
if(Array.isArray(node)){
[start,end]=node;
}elseif(typeofnode==='number'){
start=end=node;
}else{
start=node.getStart(this.ast);
end=node.getEnd();
}
part tocreateError, so other places can passnumer | Range too.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 23, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit763e7fb
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/69229981a966cc00083a395e
😎 Deploy Previewhttps://deploy-preview-11775--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 23, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit763e7fb

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 16sView ↗
nx run-many -t lint✅ Succeeded3m 15sView ↗
nx run-many -t typecheck✅ Succeeded2m 13sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx run types:build✅ Succeeded6sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-23 05:31:36 UTC

@codecov
Copy link

codecovbot commentedNov 23, 2025
edited
Loading

Codecov Report

❌ Patch coverage is36.95652% with29 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.56%. Comparing base (c421d30) to head (763e7fb).
⚠️ Report is 13 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/check-modifiers.ts0.00%24 Missing⚠️
packages/typescript-estree/src/node-utils.ts75.00%5 Missing⚠️

❌ Your patch status has failed because the patch coverage (36.95%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11775      +/-   ##==========================================- Coverage   90.57%   90.56%   -0.01%==========================================  Files         522      522                Lines       53079    53082       +3       Branches     8842     8844       +2     ==========================================+ Hits        48074    48076       +2- Misses       4989     4991       +2+ Partials       16       15       -1
FlagCoverage Δ
unittest90.56% <36.95%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/convert.ts30.97% <100.00%> (-0.10%)⬇️
packages/typescript-estree/src/node-utils.ts70.27% <75.00%> (-0.21%)⬇️
packages/typescript-estree/src/check-modifiers.ts15.92% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiskerfisker marked this pull request as ready for reviewNovember 23, 2025 07:56
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am happy either way 🙂

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 24, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit9738933 intotypescript-eslint:mainNov 26, 2025
66 of 67 checks passed
@fiskerfisker deleted the createError branchNovember 26, 2025 17:40
@fiskerfisker mentioned this pull requestNov 26, 2025
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp