typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [consistent-type-exports] check value flag before resolving alias#11769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromntdiary:fix-type-iteration

Nov 28, 2025

Merged

fix(eslint-plugin): [consistent-type-exports] check value flag before resolving alias#11769

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromntdiary:fix-type-iteration

Nov 28, 2025

Conversation

Copy link

Contributor

PR Checklist

Addresses an existing open issue:fixesBug: [consistent-type-exports] Importing a shadowing type breaks consistent-type-exports #11761
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Make sure the current symbol doesn't haveSymbolFlags.Value before resolving alias.

I submit the recursive version here, which is just 1 line shorter than thewhile iteration.
If we prefer using iteration, can be done like this:

while(symbol&&!checker.isUnknownSymbol(symbol)){if(symbol.getDeclarations()?.some(ts.isTypeOnlyImportOrExportDeclaration)){returntrue;}if(symbol.flags&ts.SymbolFlags.Value){returnfalse;}if(!(symbol.flags&ts.SymbolFlags.Alias)){returntrue;}symbol=checker.getImmediateAliasedSymbol(symbol)}returnundefined;

💖

check value flag during iteration

72369e6

Copy link

Contributor

typescript-eslintbot commentedNov 19, 2025

Thanks for the PR,@ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 19, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3e7a944`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6926a44be8334f0008cc4b3d
😎 Deploy Preview	https://deploy-preview-11769--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 1 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedNov 19, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3e7a944

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 2s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 13s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 59s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-11-26 07:06:12 UTC

ntdiary commented

Nov 19, 2025

View reviewed changes

packages/eslint-plugin/src/rules/consistent-type-exports.ts

		returnfalse;
		}
		returnsymbol.flags&ts.SymbolFlags.Alias
		?isSymbolTypeBased(checker.getImmediateAliasedSymbol(symbol))

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

replacegetAliasedSymbol withgetImmediateAliasedSymbol.
Because the latter can handle this case as well:

// a.tsexportconstNAME=1;exporttypeNAME=1;// b.tsimport{typeNAMEasFoo}from'./a';export{Foo};

Copy link

codecovbot commentedNov 19, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (17601fc) to head (3e7a944).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11769   +/-   ##=======================================  Coverage   90.49%   90.49%           =======================================  Files         522      522             Lines       53357    53359    +2       Branches     8909     8911    +2     =======================================+ Hits        48284    48286    +2  Misses       5057     5057             Partials       16       16

Flag	Coverage Δ
unittest	`90.49% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...eslint-plugin/src/rules/consistent-type-exports.ts	`96.00% <100.00%> (+0.02%)`	⬆️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merge branch 'main' into fix-type-iteration

30c7f88

JoshuaKGoldberg approved these changes

Nov 24, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for the quick fix!

Normally we try to wait a full week for changes to give @typescript-eslint/triage-team a chance to review. But since this is a fast follow and our weekly release is in a few hours, I'd like to merge today. FYI team