Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(eslint-plugin): improve vitest performance#11754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
StyleShit wants to merge2 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromStyleShit:ci/11204-vitest-performance

Conversation

@StyleShit
Copy link
Contributor

@StyleShitStyleShit commentedNov 11, 2025•
edited
Loading

Trying to help a little bit with#11204

Since all (most?) eslint-plugin tests are free of side-effects, I wondered whether we can improve the performance bydisabling isolation

On my local machine (M4 Pro, 24GB, Node v22.21.1), I saw an improvement of ~18% in an average of 3 runs.

If this works, we might be able to do this with other packages that have "pure" tests

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@StyleShit!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 11, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitba9a193
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/691398ad589ce50007760624
😎 Deploy Previewhttps://deploy-preview-11754--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@StyleShitStyleShit changed the titleci(eslint-plugin): improve vitest performancetest(eslint-plugin): improve vitest performanceNov 11, 2025
@nx-cloud
Copy link

nx-cloudbot commentedNov 11, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitba9a193

CommandStatusDurationResult
nx run-many -t lint✅ Succeeded3m 9sView ↗
nx run-many -t typecheck✅ Succeeded1m 54sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded7sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx run types:build✅ Succeeded5sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-11 20:20:26 UTC

@StyleShit
Copy link
ContributorAuthor

StyleShit commentedNov 11, 2025•
edited
Loading

Update:

After comparing it to 3 random runs (1,2,3), seems like it's indeed faster (3m 26s vs 5m 10s / 5m 1s / 4m 59s)

Not sure why itfails in Node 20 though... Seems like it's flaky for some reason. Maybe there are non-pure tests after all. will investigate when I have some time

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@StyleShit
[8]ページ先頭
©2009-2025 Movatter.jp