Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(parser): disallow invalid TS parameter property patterns ([foo], …#11753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ronakmaheshwari wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromronakmaheshwari:fix/invalid-ts-parameter-property
Open
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
importtype{AST_NODE_TYPES}from'../../ast-node-types';
importtype{Accessibility}from'../../base/Accessibility';
importtype{BaseNode}from'../../base/BaseNode';
import{Identifier}from'../../expression/spec';
importtype{Decorator}from'../../special/Decorator/spec';
importtype{BindingName}from'../../unions/BindingName';
importtype{AssignmentPattern}from'../AssignmentPattern/spec';
importtype{RestElement}from'../RestElement/spec';

exportinterfaceTSParameterPropertyextendsBaseNode{
type:AST_NODE_TYPES.TSParameterProperty;
accessibility:Accessibility|undefined;
decorators:Decorator[];
override:boolean;
parameter:AssignmentPattern|BindingName|RestElement;
parameter:Identifier|(AssignmentPattern&{left:Identifier});
readonly:boolean;
static:boolean;
}
41 changes: 40 additions & 1 deletionpackages/typescript-estree/src/convert.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1479,7 +1479,46 @@ export class Converter {
expression: false, // is not present in ESTreeNode
generator: false,
id: null,
params: this.convertParameters(node.parameters),
params: node.parameters.map((param: ts.ParameterDeclaration) => {
const parameter = this.convertChild(param) as TSESTree.Parameter;
parameter.decorators = this.convertChildren(
getDecorators(param) ?? [],
);

const hasAccessModifier =
hasModifier(param, SyntaxKind.PrivateKeyword) ||
hasModifier(param, SyntaxKind.PublicKeyword) ||
hasModifier(param, SyntaxKind.ProtectedKeyword);
const hasReadonlyModifier = hasModifier(
param,
SyntaxKind.ReadonlyKeyword,
);

if (hasAccessModifier || hasReadonlyModifier) {
const isIdentifier = parameter.type === AST_NODE_TYPES.Identifier;
const isAssignmentToIdentifier =
parameter.type === AST_NODE_TYPES.AssignmentPattern &&
(parameter.left as TSESTree.Node).type ===
AST_NODE_TYPES.Identifier;

if (!isIdentifier && !isAssignmentToIdentifier) {
this.#throwError(
param,
'Invalid TS parameter property: only `Identifier` or `AssignmentPattern` (with Identifier left-hand side) are allowed.',
);
}
return this.createNode(param, {
type: AST_NODE_TYPES.TSParameterProperty,
accessibility: getTSNodeAccessibility(param),
readonly: hasReadonlyModifier,
override: hasModifier(param, SyntaxKind.OverrideKeyword),
static: hasModifier(param, SyntaxKind.StaticKeyword),
decorators: this.convertChildren(getDecorators(param) ?? []),
parameter,
});
}
return parameter;
}),
returnType: node.type && this.convertTypeAnnotation(node.type, node),
typeParameters:
node.typeParameters &&
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
// class Invalid1 {
// constructor(private [foo] = [1]) {}
// }
// class Invalid2 {
// constructor(private { bar } = { bar: 1 }) {}
// }
// class Invalid3 {
// constructor(private ...baz) {}
// }
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
class Valid1 {
constructor(private foo: number) {}
}
class Valid2 {
constructor(private foo = 1) {}
}
class Valid3 {
constructor(public readonly bar?: string) {}
}
Loading
[8]ページ先頭
©2009-2025 Movatter.jp