Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: extract AST check from convert.ts to ast-checks.ts#11748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Lonercode wants to merge5 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromLonercode:extract-ast-checks-from-converter

Conversation

@Lonercode
Copy link

PR Checklist

Overview

This PR extracts the AST check (checkForStatementDeclaration) fromconvert.ts to a fileast-checks.ts as requested in the issue due to the increasing length of code in the file. Therefore, a new fie has been added (ast-checks.ts), one modified (convert.ts) and tests have been run.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Lonercode!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 9, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit65803e4
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6910bfa442fbcb0008123629
😎 Deploy Previewhttps://deploy-preview-11748--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 9, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit65803e4

CommandStatusDurationResult
nx run-many -t lint✅ Succeeded3m 7sView ↗
nx run-many -t typecheck✅ Succeeded2mView ↗
nx test typescript-estree --coverage=false✅ Succeeded19sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded4sView ↗
nx run types:build✅ Succeeded15sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded7sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-09 16:30:10 UTC

@LonercodeLonercode changed the titleChore: Extract AST check from convert.ts to ast-checks.tschore: Extract AST check from convert.ts to ast-checks.tsNov 9, 2025
@codecov
Copy link

codecovbot commentedNov 9, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is97.95918% with1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.74%. Comparing base (189a7f7) to head (65803e4).

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts50.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #11748      +/-   ##==========================================+ Coverage   90.66%   90.74%   +0.08%==========================================  Files         518      519       +1       Lines       52444    52453       +9       Branches     8690     8709      +19     ==========================================+ Hits        47548    47601      +53+ Misses       4882     4838      -44  Partials       14       14
FlagCoverage Δ
unittest90.74% <97.95%> (+0.08%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/ast-checks.ts100.00% <100.00%> (ø)
packages/typescript-estree/src/convert.ts31.49% <50.00%> (+0.43%)⬆️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LonercodeLonercode changed the titlechore: Extract AST check from convert.ts to ast-checks.tschore: extract AST check from convert.ts to ast-checks.tsNov 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Extract AST check fromConverter

1 participant

@Lonercode
[8]ページ先頭
©2009-2025 Movatter.jp