Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(scope-manager): throws unhelpfulaaa error message becauseanalyze expectsProgram#11747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nayounsang wants to merge4 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromnayounsang:scope-aaa

Conversation

@nayounsang
Copy link
Contributor

@nayounsangnayounsang commentedNov 9, 2025•
edited
Loading

PR Checklist

Overview

  1. change type arg of analyze: Program
  2. change err msg, notaaa

Since changed the type ofanalyze, I'm wondering if it's correct to write the test as it is now.(I don't know if that makes sense!)

And I'd like to know what happens when the range option isn't set. I'll leave it as a draft. I haven't been able to reproduce it yet.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nayounsangnayounsang marked this pull request as draftNovember 9, 2025 14:30
@netlify
Copy link

netlifybot commentedNov 9, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1282ebc
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6910a5779626700008eb8d0f
😎 Deploy Previewhttps://deploy-preview-11747--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 9, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit1282ebc

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 12sView ↗
nx run-many -t lint✅ Succeeded3m 5sView ↗
nx run-many -t typecheck✅ Succeeded2m 8sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-09 14:43:05 UTC

@nayounsangnayounsang changed the titlefix(scope-manager):scope-manager throws unhelpfulaaa error message becauseanalyze expectsProgramfix(scope-manager): scope-manager throws unhelpfulaaa error message becauseanalyze expectsProgramNov 9, 2025
@nayounsangnayounsang changed the titlefix(scope-manager): scope-manager throws unhelpfulaaa error message becauseanalyze expectsProgramfix(scope-manager): throws unhelpfulaaa error message becauseanalyze expectsProgramNov 9, 2025
@codecov
Copy link

codecovbot commentedNov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (189a7f7) to head (1282ebc).

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11747   +/-   ##=======================================  Coverage   90.66%   90.67%           =======================================  Files         518      518             Lines       52444    52447    +3       Branches     8690     8691    +1     =======================================+ Hits        47548    47554    +6+ Misses       4882     4879    -3  Partials       14       14
FlagCoverage Δ
unittest90.67% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/scope-manager/src/analyze.ts100.00% <100.00%> (ø)
...ackages/scope-manager/src/referencer/Referencer.ts97.94% <100.00%> (+<0.01%)⬆️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: scope-manager throws unhelpfulaaa error message

1 participant

@nayounsang
[8]ページ先頭
©2009-2025 Movatter.jp