typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore(eslint-plugin-internal): correct documentation URLs with undefined version#11736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

azat-io wants to merge2 commits intotypescript-eslint:main

base:main

Choose a base branch

fromazat-io:fix/internal-plugin-url

Open

chore(eslint-plugin-internal): correct documentation URLs with undefined version#11736

azat-io wants to merge2 commits intotypescript-eslint:mainfromazat-io:fix/internal-plugin-url

+1 −5

Conversation

Copy link

Contributor

azat-io commentedNov 3, 2025

Fixed broken documentation URLs in@typescript-eslint/eslint-plugin-internal rules that were showingvundefined in the path.

The internal plugin package is private and didn't have aversion field inpackage.json, causingundefined to be interpolated into documentation URLs.

Before:

https://github.com/typescript-eslint/typescript-eslint/blob/vundefined/packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts

After:

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts

fix(eslint-plugin-internal): correct documentation URLs with undefine…

f841720

…d version

Copy link

Contributor

typescript-eslintbot commentedNov 3, 2025

Thanks for the PR,@azat-io!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 3, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0909429`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/69093097c3d4b2000810a7ab
😎 Deploy Preview	https://deploy-preview-11736--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 4 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedNov 3, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit0909429

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 6s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 9s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	10s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-11-03 22:52:19 UTC

Copy link

codecovbot commentedNov 3, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.64%. Comparing base (ea2ee6b) to head (0909429).

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11736      +/-   ##==========================================- Coverage   90.66%   90.64%   -0.02%==========================================  Files         518      518                Lines       52435    52435                Branches     8686     8686              ==========================================- Hits        47541    47532       -9- Misses       4880     4889       +9  Partials       14       14

Flag	Coverage Δ
unittest	`90.64% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merge branch 'main' into fix/internal-plugin-url

0909429

kirkwaiblinger approved these changes

Nov 5, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, yeah, I'd been meaning to file an issue about this. Thanks for fixing!

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Nov 5, 2025

kirkwaiblinger changed the title~~fix(eslint-plugin-internal): correct documentation URLs with undefined version~~chore(eslint-plugin-internal): correct documentation URLs with undefined version

Nov 5, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(eslint-plugin-internal): correct documentation URLs with undefined version#11736

Are you sure you want to change the base?

chore(eslint-plugin-internal): correct documentation URLs with undefined version#11736