While working on#11720, I noticed that the return type of the function is typed as a callback with one parameter, but is actually returning a callback with two parameters. It's now using the correct type and simultaneously with five lines less code.

refactor(eslint-plugin): use correct type for return type of `createV…

6c795d7

…alidator`

Copy link

Contributor

typescript-eslintbot commentedOct 25, 2025

Thanks for the PR,@ulrichstark!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 25, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`6c795d7`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68fd5021083bfd00086574dc
😎 Deploy Preview	https://deploy-preview-11721--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 Accessibility: 97 Best Practices: 100 SEO: 92 PWA: 80 View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedOct 25, 2025•
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable themin workspace settings.}

View yourCI Pipeline Execution ↗ for commit6c795d7

Command	Status	Duration	Result
`nx run integration-tests:test`	❌ Failed	52s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4m 58s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 4s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 8s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	6s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-10-25 22:45:15 UTC

Copy link

codecovbot commentedOct 25, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (55ca033) to head (6c795d7).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11721      +/-   ##==========================================- Coverage   90.66%   90.66%   -0.01%==========================================  Files         518      518                Lines       52415    52412       -3       Branches     8678     8678              ==========================================- Hits        47521    47518       -3  Misses       4880     4880                Partials       14       14

Flag	Coverage Δ
unittest	`90.66% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...gin/src/rules/naming-convention-utils/validator.ts	`98.37% <100.00%> (-0.02%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ulrichstark changed the title~~refactor(eslint-plugin): use correct type for return type ofcreateValidator~~chore(eslint-plugin): use correct type for return type ofcreateValidator

Oct 25, 2025