Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): replace unclear "error typed" with more helpful description#11704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -73,7 +73,7 @@ export default createRule<[], MessageIds>({ | ||
| node: reportingNode, | ||
| messageId, | ||
| data: { | ||
| type: isErrorType ? 'unresolved due to error' : '`any`', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more.
🤔 yeah, I'm not sure that this specific change is better for users. Looking atthe deploy preview playground, the report message is: It took me a few tries to parse out the English grammar in that sentence, and I had to rely on already knowing the rule & this PR. I'm drawing a blank here (and am a little swamped), but let's bikeshed. What's a more clear phrase we could go with? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Using an entirely new message would be best. Something along the lines of "Unsafe call of a type that could not be resolved." That's what I originally started doing in this PR, but then I had to touch more files than I wanted to, so I changed to the kludgy phrasing. | ||
| }, | ||
| }); | ||
| return; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -289,7 +289,7 @@ value(); | ||
| { | ||
| column: 1, | ||
| data: { | ||
| type: 'unresolved due to error', | ||
| }, | ||
| endColumn: 6, | ||
| line: 3, | ||
Uh oh!
There was an error while loading.Please reload this page.