Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [prefer-optional-chain] skip optional chaining when it could change the result#11702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Thanks for the PR,@mdm317! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedOct 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedOct 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitfd98e65
☁️Nx Cloud last updated this comment at |
codecovbot commentedOct 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #11702 +/- ##==========================================- Coverage 90.67% 90.66% -0.01%========================================== Files 518 518 Lines 52466 52415 -51 Branches 8694 8679 -15 ==========================================- Hits 47571 47520 -51 Misses 4881 4881 Partials 14 14
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
| `, | ||
| ` | ||
| declare const foo: { bar: number }; | ||
| foo != null && foo.bar !== x; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks likex is undeclared here, so this is an error type. Might be good to make it explicit?
| 'foo != null && foo.bar != x;', | ||
| ` | ||
| declare const foo: { bar: number }; | ||
| foo && foo.bar == x; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's declarex with a type here? Unless we're intentionally testing undeclared variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn’t declare it because I wanted to test that it doesn’t convert to an optional chain when we don’t knowx’s type.
But thinking about what you said, testing with an error type feels odd and doesn’t clearly show the test’s purpose.
How about declaring x with the typeany instead?
kirkwaiblingerOct 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think both are potentially valid tests! But I would just make the intention explicit like:
declareconstfoo:{bar:number};declareconstanee:any;foo&&foo.bar==anee;
// intentionally tests that an undeclared variable doesn't trigger an autofixdeclareconstfoo:{bar:number};foo&&foo.bar==undeclaredVar;
kirkwaiblingerOct 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like there's a minor bug somewhere with:
declareconstfoo:{bar:number|null}|undefined;if(foo===undefined||foo.bar===null){// suggests to foo?.bar === null, which is not equivalent.}else{foo.bar.toExponential();// after accepting fix, this crashes if `foo` is `undefined`.}
I guess this should either not report or it could maybe try to usefoo?.bar == null? But this seems kind of bad since it is impossible to work with for an=== nullishValue-prefering user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typescript-eslint/packages/eslint-plugin/src/rules/prefer-optional-chain-utils/analyzeChain.ts
Lines 277 to 284 in3f5fbf6
if( includesType(parserServices,operand.comparedName,ts.TypeFlags.Null) ){ // we know the next operand is not a `null` check and that this // operand includes `null` - which means that making this an // optional chain would change the runtime behavior of the expression returnnull; }
I believe this bug didn’t originate from this PR — it seems to have existed beforehand.
Since I wasn’t the original author, it might take some time to fix it properly.
If possible, we could apply a quick hotfix for the current issue first and then open a new issue to track it, but it’s just a suggestion — feel free to decide as you think best.
In any case, I’ll start digging into it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
kirkwaiblinger left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like it's on the right track, but minor touchups and a question about one bug that I saw.
Thanks for looking at this so quickly! ❤️
698e7a8 intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.2 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.2 |## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.2 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.2 |## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.2 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.2 |## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.2 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.2 |## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.2 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.2 |## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.3 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.3 |## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.3 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.3 |## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.4 || npm | @typescript-eslint/parser | 8.46.1 | 8.46.4 |## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
This PR contains the following updates:| Package | Change | Age | Confidence ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) || [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#​10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@​bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#​11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#​11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#​11006](typescript-eslint/typescript-eslint#11006), [#​10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@​undsoft](https://github.com/undsoft)- Kentaro Suzuki [@​sushichan044](https://github.com/sushichan044)- Maria Solano [@​MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#​11722](typescript-eslint/typescript-eslint#11722), [#​11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#​11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@​undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#​11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#​11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#​11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)##### 🚀 Features- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#​11659](typescript-eslint/typescript-eslint#11659))- **rule-schema-to-typescript-types:** clean up and make public ([#​11633](typescript-eslint/typescript-eslint#11633))##### 🩹 Fixes- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#​11660](typescript-eslint/typescript-eslint#11660))- **typescript-estree:** forbid abstract method and accessor to have implementation ([#​11657](typescript-eslint/typescript-eslint#11657))- **eslint-plugin:** removed error type previously deprecated ([#​11674](typescript-eslint/typescript-eslint#11674))- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#​11603](typescript-eslint/typescript-eslint#11603))- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#​11634](typescript-eslint/typescript-eslint#11634))- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#​11628](typescript-eslint/typescript-eslint#11628))- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#​11487](typescript-eslint/typescript-eslint#11487))##### ❤️ Thank You- fisker Cheung [@​fisker](https://github.com/fisker)- Josh Goldberg ✨- Kirk Waiblinger [@​kirkwaiblinger](https://github.com/kirkwaiblinger)- Mark de Dios [@​peanutenthusiast](https://github.com/peanutenthusiast)- Richard Torres [@​richardtorres314](https://github.com/richardtorres314)- Victor Genaev [@​mainframev](https://github.com/mainframev)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#​11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#​11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#​11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@​thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@​y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#​11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#​11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#​11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@​kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#​11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#​11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@​thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#​11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#​11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#​11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#​11423](typescript-eslint/typescript-eslint#11423), [#​11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#​11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#​11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#​11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#​11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#​11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@​dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@​kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@​mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@​y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@​mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)##### 🩹 Fixes- **deps:** update eslint monorepo to v9.33.0 ([#​11482](typescript-eslint/typescript-eslint#11482))You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)##### 🩹 Fixes- **deps:** update dependency prettier to v3.6.2 ([#​11496](typescript-eslint/typescript-eslint#11496))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)##### 🚀 Features- **typescript-estree:** forbid invalid keys in `EnumMember` ([#​11232](typescript-eslint/typescript-eslint#11232))##### ❤️ Thank You- fisker Cheung [@​fisker](https://github.com/fisker)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Reviewed-on:https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20Co-authored-by: Renovate Bot <renovate@csmpro.ru>Co-committed-by: Renovate Bot <renovate@csmpro.ru>
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm | @typescript-eslint/parser | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm | @typescript-eslint/parser | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm | @typescript-eslint/parser | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
When applying optional chaining, if the transformation has the potential to alter the evaluation result,
the previous operand should not be included, even when it appears useless.
Conversely, if the transformation is guaranteed to preserve the result,
the previous operand should be included in the chain, even when it’s useless.
Not convert to optional-chain
Conver to optional-chain
see Algorithm