Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): forbid invalid modifiers in object methods#11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fisker
Copy link
Contributor

@fiskerfisker commentedOct 9, 2025•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 9, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite52f52e
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68e7af756cb4920008db8d07
😎 Deploy Previewhttps://deploy-preview-11689--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedOct 9, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commite52f52e

CommandStatusDurationResult
nx run-many -t lint✅ Succeeded3m 15sView ↗
nx run-many -t typecheck✅ Succeeded1m 53sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded3sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-10-09 13:01:48 UTC

@fiskerfiskerforce-pushed theobject-modifier branch 2 times, most recently from16fcab8 to995e312CompareOctober 9, 2025 11:46
@codecov
Copy link

codecovbot commentedOct 9, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (de1fedb) to head (e52f52e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11689   +/-   ##=======================================  Coverage   90.67%   90.67%           =======================================  Files         518      518             Lines       52466    52466             Branches     8694     8693    -1     =======================================+ Hits        47571    47572    +1+ Misses       4881     4880    -1  Partials       14       14
FlagCoverage Δ
unittest90.67% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/check-modifiers.ts15.92% <100.00%> (+0.31%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiskerfisker changed the titlefix(typescript-estree): forbid invalid modifiers in object propertiesfix(typescript-estree): forbid invalid modifiers in object methodsOct 9, 2025
Comment on lines +19 to +41
"expression/ObjectExpression/fixtures/_error_/getter-modifier-declare/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/getter-modifier-export/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/getter-modifier-override/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/getter-modifier-private/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/getter-modifier-protected/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/getter-modifier-public/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/getter-modifier-static/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-abstract/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-async/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-declare/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-export/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-override/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-private/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-protected/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-public/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/property-modifier-static/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-declare/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-export/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-override/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-private/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-protected/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-public/fixture.ts",
"expression/ObjectExpression/fixtures/_error_/setter-modifier-static/fixture.ts",
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Turns out there is something wrong ingetModifiers() utility, I can't get all modifiers, so these are not easy to fix.

Let's keep these as TODO?

#11688 can be addressed in another PR.

JoshuaKGoldberg reacted with thumbs up emoji
@fiskerfisker marked this pull request as ready for reviewOctober 9, 2025 13:00
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commit4eda303 intotypescript-eslint:mainOct 20, 2025
69 checks passed
@fiskerfisker deleted the object-modifier branchOctober 20, 2025 15:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: Forbid invalid modifiers in object methods

2 participants

@fisker@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp