typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [no-misused-promises] special-case`.finally` not to report when a promise returning function is provided as an argument#11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromronami:no-misused-promises-ignore-promise-finally

Oct 8, 2025

Merged

fix(eslint-plugin): [no-misused-promises] special-case`.finally` not to report when a promise returning function is provided as an argument#11667

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromronami:no-misused-promises-ignore-promise-finally

Oct 8, 2025

+29 −0

Conversation

Copy link

Member

ronami commentedSep 30, 2025

PR Checklist

Addresses an existing open issue:fixesBug: [no-misused-promises] versus Promise.finally #10959
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR addresses#10959 and special-cases the.finally handler not to report when a promise returning function is provided as an argument:

Promise.reject(3).finally(async()=>{});

initial implementation

d63ef18

Copy link

Contributor

typescript-eslintbot commentedSep 30, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 30, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`be919d8`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68dedabe1f3aab0008ccdf29
😎 Deploy Preview	https://deploy-preview-11667--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 18 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 30, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitbe919d8

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 13s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 9s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 6s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	6s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-10-02 20:16:52 UTC

Copy link

codecovbot commentedSep 30, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.96%. Comparing base (db09a7d) to head (be919d8).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11667      +/-   ##==========================================+ Coverage   90.93%   90.96%   +0.02%==========================================  Files         506      506                Lines       51397    51449      +52       Branches     8484     8495      +11     ==========================================+ Hits        46738    46799      +61+ Misses       4646     4637       -9  Partials       13       13

Flag	Coverage Δ
unittest	`90.96% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`99.12% <100.00%> (+0.01%)`	⬆️

... and12 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.