Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Revert "feat(eslint-plugin): expose rule name via RuleModule interface"#11663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedSep 29, 2025•
edited
Loading

Reverts#11616

I'd like to get the change back in, but it's non-trivial to work around#11662.

Fixes#11662.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 29, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc80d100
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68dacf387a00670008e5b024
😎 Deploy Previewhttps://deploy-preview-11663--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🟢 up 14 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 29, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc80d100

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 16sView ↗
nx run-many -t lint✅ Succeeded3m 9sView ↗
nx run-many -t typecheck✅ Succeeded2m 9sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-29 18:42:18 UTC

Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't remember the details, but I remember previously nx was super picky about the PR title for a revert PR, so might be worth double checking that before merging

JoshuaKGoldberg reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitdb09a7d intomainSep 29, 2025
66 of 69 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the revert-11616-feat/add-name-to-rulemodule branchSeptember 29, 2025 20:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: (regression)name should be optional in RuleCreator.withoutDocs
2 participants
@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp