Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Revert "feat(eslint-plugin): expose rule name via RuleModule interface"#11663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedSep 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedSep 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitc80d100
☁️Nx Cloud last updated this comment at |
kirkwaiblinger left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't remember the details, but I remember previously nx was super picky about the PR title for a revert PR, so might be worth double checking that before merging
db09a7d intomainUh oh!
There was an error while loading.Please reload this page.
jfirebaugh commentedNov 20, 2025
This is a breaking change, no? Now fails to typecheck with v8.46.0+. |
bradzacher commentedNov 20, 2025
It was added in one version and immediately removed in the next version because it introduced bugs. From our POV that is NOT a breaking change - it should not have landed at all. |
kirkwaiblinger commentedNov 20, 2025
@jfirebaugh FWIW we were intending to do an immediate patch release to revert it, but ran into CI/automation issues, so it ended up just going out as part of the next regularly-scheduled minor, rather than its own patch. |
jfirebaugh commentedNov 21, 2025
I see... I guess we upgraded at exactly the wrong time, such that we had to add |

Uh oh!
There was an error while loading.Please reload this page.
Reverts#11616
I'd like to get the change back in, but it's non-trivial to work around#11662.
Fixes#11662.