Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [prefer-readonly-parameter-types] ignore tagged primitives#11660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedSep 29, 2025•
edited
Loading

PR Checklist

Overview

Adds a special-case exemption for an intersection of a literal and an object, as suggested in#1790 (comment).

I think Codecov is wrong to complain. The new functions are hit. We're just not merging coverage reports.

💖

ronami reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 29, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitbea544c
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68e3b29c28623e0008ccc702
😎 Deploy Previewhttps://deploy-preview-11660--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 75 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 29, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitbea544c

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 5sView ↗
nx run-many -t lint✅ Succeeded3m 20sView ↗
nx run-many -t typecheck✅ Succeeded2m 3sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded11sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded5sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-10-06 12:27:49 UTC

@codecovCodecov
Copy link

codecovbot commentedSep 29, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is9.52381% with38 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.67%. Comparing base (7f5fed7) to head (bea544c).
⚠️ Report is 9 commits behind head on main.

Files with missing linesPatch %Lines
...ackages/type-utils/src/isTypeBrandedLiteralLike.ts7.31%38 Missing⚠️

❌ Your patch status has failed because the patch coverage (9.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11660      +/-   ##==========================================- Coverage   90.74%   90.67%   -0.07%==========================================  Files         516      517       +1       Lines       51987    52028      +41       Branches     8588     8588              ==========================================+ Hits        47174    47177       +3- Misses       4799     4837      +38  Partials       14       14
FlagCoverage Δ
unittest90.67% <9.52%> (-0.07%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...lugin/src/rules/prefer-readonly-parameter-types.ts100.00% <100.00%> (ø)
...ackages/type-utils/src/isTypeBrandedLiteralLike.ts7.31% <7.31%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 29, 2025 12:12
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking great! Just a few questions/nits from me 🚀🚀🚀

@ronamironami added the awaiting responseIssues waiting for a reply from the OP or another party labelSep 29, 2025
@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelSep 30, 2025
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀🚀🚀 Looking good!

I added a couple of comments, mostly around a case I missed on the last review (my apologies).

@ronamironami added the awaiting responseIssues waiting for a reply from the OP or another party labelOct 4, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 6, 2025
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤩

JoshuaKGoldberg reacted with rocket emoji
@ronamironami added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 6, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commita974191 intotypescript-eslint:mainOct 6, 2025
67 of 68 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the prefer-readonly-parameter-types-tagged-primitive branchOctober 6, 2025 13:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ronamironamironami approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] false positive with tagged primitive type
2 participants
@JoshuaKGoldberg@ronami
[8]ページ先頭
©2009-2025 Movatter.jp