typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(typescript-estree): forbid abstract method and accessor to have implementation#11657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromfisker:class-abstract-method

Oct 6, 2025

Merged

fix(typescript-estree): forbid abstract method and accessor to have implementation#11657

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromfisker:class-abstract-method

Oct 6, 2025

+143 −16

Conversation

Copy link

Contributor

fisker commentedSep 28, 2025•
edited by JoshuaKGoldberg
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: Forbid abstract method to have implementation #11653fixesEnhancement: Forbid abstract accessor to have implementation #11654
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Copy link

Contributor

typescript-eslintbot commentedSep 28, 2025

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 28, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c30d11d`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68dac51c1c7f4d000885cb4c
😎 Deploy Preview	https://deploy-preview-11657--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🟢 up 6 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 28, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc30d11d

Command	Status	Duration	Result
`nx run-many -t typecheck`	✅ Succeeded	2m	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 15s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	3s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-29 17:49:21 UTC

fisker force-pushed theclass-abstract-method branch fromfcd0b87 to4230204Compare

September 28, 2025 15:08

Copy link

codecovbot commentedSep 29, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is5.55556% with17 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.90%. Comparing base (967764e) to head (c30d11d).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	0.00%	11 Missing⚠️
packages/typescript-estree/src/node-utils.ts	14.28%	6 Missing⚠️

❌ Your patch status has failed because the patch coverage (5.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11657      +/-   ##==========================================- Coverage   90.93%   90.90%   -0.03%==========================================  Files         506      506                Lines       51400    51414      +14       Branches     8484     8483       -1     ==========================================- Hits        46741    46739       -2- Misses       4646     4662      +16  Partials       13       13

Flag	Coverage Δ
unittest	`90.90% <5.55%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/node-utils.ts	`62.50% <14.28%> (-0.55%)`	⬇️
packages/typescript-estree/src/convert.ts	`30.16% <0.00%> (-0.07%)`	⬇️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fisker force-pushed theclass-abstract-method branch from2d59c8f to1d5e23cCompare

September 29, 2025 16:42

fisker changed the title~~fix(typescript-estree): forbid abstract method to have implementation~~fix(typescript-estree): forbid abstract method and accessor to have implementation

Sep 29, 2025

fisker marked this pull request as draft

September 29, 2025 16:56

fisker marked this pull request as ready for review

September 29, 2025 17:42

fisker added8 commits

September 30, 2025 01:42

fix(typescript-estree): forbid abstract method to have implementation

5e37414

One more test

7fbd6e6

Fix tests?

f936621

Fix rule tests

a187b90

Fix test

8c9ad39

Fix test

101d790

Accessor

5ca86a8

constructor

c30d11d

fisker force-pushed theclass-abstract-method branch frome6587ff toc30d11dCompare

September 29, 2025 17:42

JoshuaKGoldberg requested changes

Oct 3, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fantastic - very clean and thorough. Nice!

Just requesting the one(Missing) case be tested or removed. Otherwise this looks ready to go to me.

packages/eslint-plugin/tests/rules/naming-convention/naming-convention.test.ts

Copy link

Member

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] Nice, always happy to see this file cleaned up.

packages/typescript-estree/src/node-utils.ts

		ast:ts.SourceFile,
		):string{
		consttext=ast.text.slice(name.pos,name.end).trimStart();
		returntext\|\|'(Missing)';

Copy link

Member

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

'(Missing)'

[Testing] This doesn't show up in any of the snapshots. Can you either add a test showing it (if it's possible?) or remove it?

Copy link

ContributorAuthor

fiskerOct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This originaldeclarationNameToString from typescript package have this, so I guess it's possible, but I don't know how to test.

Copy link

Member

JoshuaKGoldbergOct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 makes sense, I think it's reasonable to leave in then. Thanks.

packages/typescript-estree/src/convert.ts

		node.kind===SyntaxKind.GetAccessor\|\|
		node.kind===SyntaxKind.SetAccessor
		?'An abstract accessor cannot have an implementation.'
		:`Method '${declarationNameToString(node.name,this.ast)}' cannot have an implementation because it is marked abstract.`,

Copy link

Member

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] These are great error messages! 👏

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 3, 2025

JoshuaKGoldberg merged commit02e0278 intotypescript-eslint:main

Oct 6, 2025

64 of 66 checks passed

fisker deleted the class-abstract-method branch

October 6, 2025 14:10

Labels

awaiting response

Issues waiting for a reply from the OP or another party

2 participants

Movatterモバイル変換

Uh oh!

fix(typescript-estree): forbid abstract method and accessor to have implementation#11657

fix(typescript-estree): forbid abstract method and accessor to have implementation#11657

Conversation

fisker commentedSep 28, 2025• edited by JoshuaKGoldbergLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedSep 28, 2025

Uh oh!

netlifybot commentedSep 28, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedSep 28, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedSep 29, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

Uh oh!

fiskerOct 4, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergOct 6, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fisker commentedSep 28, 2025•
edited by JoshuaKGoldberg
Loading

netlifybot commentedSep 28, 2025•
edited
Loading

nx-cloudbot commentedSep 28, 2025•
edited
Loading

codecovbot commentedSep 29, 2025•
edited
Loading