typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(typescript-estree): forbid`abstract` modifier in object methods#11656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromfisker:object-abstract-method

Oct 6, 2025

Merged

fix(typescript-estree): forbid`abstract` modifier in object methods#11656

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromfisker:object-abstract-method

Oct 6, 2025

Conversation

Copy link

Contributor

fisker commentedSep 28, 2025•
edited by JoshuaKGoldberg
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: Forbidabstract modifier in object methods #11655
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(typescript-estree): forbidabstract modifier in object methods

f898407

Copy link

Contributor

typescript-eslintbot commentedSep 28, 2025

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 28, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`7d22df7`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68e3b51f0416fc0008db3297
😎 Deploy Preview	https://deploy-preview-11656--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 19 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 28, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit7d22df7

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 8s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 14s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 3s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	20s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	10s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	8s	View ↗
`nx run generate-configs`	✅ Succeeded	10s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-10-06 12:38:28 UTC

fisker marked this pull request as ready for review

September 28, 2025 14:09

Copy link

codecovbot commentedSep 28, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is10.00000% with9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.73%. Comparing base (a62f625) to head (7d22df7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/check-modifiers.ts	10.00%	9 Missing⚠️

❌ Your patch status has failed because the patch coverage (10.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11656      +/-   ##==========================================- Coverage   90.74%   90.73%   -0.02%==========================================  Files         516      516                Lines       51987    52023      +36       Branches     8588     8597       +9     ==========================================+ Hits        47174    47201      +27- Misses       4799     4808       +9  Partials       14       14

Flag	Coverage Δ
unittest	`90.73% <10.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/check-modifiers.ts	`15.60% <10.00%> (-0.19%)`	⬇️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg reviewed

Oct 3, 2025

View reviewed changes

packages/typescript-estree/src/convert.ts Outdated

		}
		}

		// TODO: There are more cases in `checkGrammarObjectLiteralExpression` in typescript

Copy link

Member

JoshuaKGoldbergOct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Docs] I don't follow the intent of this comment. Do you plan to file issues / send PRs for more of them?

Copy link

ContributorAuthor

fiskerOct 4, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't follow the intent of this comment.

My idea is to leave a reference to track where it come from like other conditions. But this part fromcheckGrammarObjectLiteralExpression is not full covered.