typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore: enable eslint-plugin/require-meta-schema-description internally#11647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:require-meta-schema-description

Sep 30, 2025

Merged

chore: enable eslint-plugin/require-meta-schema-description internally#11647

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:require-meta-schema-description

Sep 30, 2025

Conversation

Copy link

Member

JoshuaKGoldberg commentedSep 26, 2025

PR Checklist

Addresses an existing open issue:fixesRepo: Use a lint rule to require rule options schema properties include a description #9866
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Removes the disable ofeslint-plugin/require-meta-schema-description, and adds descriptions as requested.

💖

chore: enable eslint-plugin/require-meta-schema-description internally

ddcfe52

Copy link

Contributor

typescript-eslintbot commentedSep 26, 2025

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 26, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f12fc3c`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68da72ee32ad240008fd00b7
😎 Deploy Preview	https://deploy-preview-11647--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 76 (🔴 down 17 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 26, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf12fc3c

Command	Status	Duration	Result
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	11s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 2s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	3m 2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 8s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-29 12:18:46 UTC

bradzacher approved these changes

Sep 26, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Sep 26, 2025

Merge branch 'main' into require-meta-schema-description

f12fc3c

Copy link

codecovbot commentedSep 29, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.94%. Comparing base (9530e02) to head (f12fc3c).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11647   +/-   ##=======================================  Coverage   90.93%   90.94%           =======================================  Files         506      506             Lines       51394    51442   +48       Branches     8482     8482           =======================================+ Hits        46735    46783   +48  Misses       4646     4646             Partials       13       13

Flag	Coverage Δ
unittest	`90.94% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts	`91.32% <100.00%> (+0.03%)`	⬆️
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`100.00% <100.00%> (ø)`
...-plugin/src/rules/explicit-member-accessibility.ts	`99.07% <100.00%> (+0.05%)`	⬆️
...ackages/eslint-plugin/src/rules/member-ordering.ts	`99.21% <100.00%> (+<0.01%)`	⬆️
.../eslint-plugin/src/rules/method-signature-style.ts	`93.45% <100.00%> (+0.03%)`	⬆️
...slint-plugin/src/rules/no-unnecessary-condition.ts	`99.57% <100.00%> (+<0.01%)`	⬆️
packages/eslint-plugin/src/rules/no-unused-vars.ts	`100.00% <100.00%> (ø)`
...es/eslint-plugin/src/rules/no-use-before-define.ts	`98.24% <100.00%> (+0.01%)`	⬆️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.