fix(ast-spec): narrow ArrowFunctionExpression.generator to false#11636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:mainfromJoshuaKGoldberg:ast-arrow-function-expression-generator-false

Sep 27, 2025

Merged

fix(ast-spec): narrow ArrowFunctionExpression.generator to false#11636

bradzacher merged 1 commit intotypescript-eslint:mainfromJoshuaKGoldberg:ast-arrow-function-expression-generator-false

Sep 27, 2025

Conversation

Copy link

Member

JoshuaKGoldberg commentedSep 26, 2025

PR Checklist

Addresses an existing open issue:fixesBug: ArrowFunctionExpression's generator property should always be false #8140
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Narrows it from the generalboolean tofalse per discussion in the issue.

💖

fix(ast-spec): narrow ArrowFunctionExpression.generator to false

96c5596

Copy link

Contributor

typescript-eslintbot commentedSep 26, 2025

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 26, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`96c5596`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68d6980f82364a0009788b14
😎 Deploy Preview	https://deploy-preview-11636--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 6 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 26, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit96c5596

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 10s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 13s	View ↗
`nx run types:build`	✅ Succeeded	6s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	9s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗