Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [unbound-method] improve wording aroundthis: void and binding#11634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Generally applies the phrasing suggested in#10056 (comment). I also tweaked theunboundWithoutThisAnnotation to speak generally, rather than suggest user action on the specific function.

Co-authored-by:@kirkwaiblinger

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 26, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5850431
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68d6933e9a90b500081426fb
😎 Deploy Previewhttps://deploy-preview-11634--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 26, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit5850431

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 7sView ↗
nx run-many -t lint✅ Succeeded3m 19sView ↗
nx run-many -t typecheck✅ Succeeded2m 7sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx run types:build✅ Succeeded6sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
nx run generate-configs✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-26 13:33:44 UTC

@codecovCodecov
Copy link

codecovbot commentedSep 26, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (9fd1cc6) to head (5850431).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11634   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51370    51372    +2       Branches     8476     8476           =======================================+ Hits        46711    46713    +2  Misses       4646     4646             Partials       13       13
FlagCoverage Δ
unittest90.93% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts99.08% <100.00%> (+<0.01%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 26, 2025 13:34
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 29, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit760d299 intotypescript-eslint:mainOct 3, 2025
64 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ronamironamironami approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [unbound-method] Reword message to better explainthis: void binding
3 participants
@JoshuaKGoldberg@ronami@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp