Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(rule-schema-to-typescript-types): clean up and make public#11633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(rule-schema-to-typescript-types): clean up and make public#11633
Conversation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedSep 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedSep 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitea6b7c9
☁️Nx Cloud last updated this comment at |
codecovbot commentedSep 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #11633 +/- ##==========================================- Coverage 90.96% 90.74% -0.22%========================================== Files 506 514 +8 Lines 51447 51947 +500 Branches 8493 8584 +91 ==========================================+ Hits 46797 47139 +342- Misses 4637 4794 +157- Partials 13 14 +1
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Excited to see this coming online!
It looks like these lists could be updated to includerule-schema-to-typescript-types
.
typescript-eslint/.github/ISSUE_TEMPLATE/06-bug-report-other.yaml
Lines 39 to 53 in4ad8a07
options: | |
-ast-spec | |
-eslint-plugin | |
-parser | |
-project-service | |
-rule-tester | |
-scope-manager | |
-tsconfig-utils | |
-type-utils | |
-types | |
-typescript-eslint | |
-typescript-estree | |
-utils | |
-visitor-keys | |
-website |
options: | |
-ast-spec | |
-eslint-plugin | |
-parser | |
-project-service | |
-rule-tester | |
-scope-manager | |
-tsconfig-utils | |
-type-utils | |
-types | |
-typescript-eslint | |
-typescript-estree | |
-utils | |
-visitor-keys | |
-website |
That would help users like me to submit issues specifically related to this tool.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Francesco Trotta <github@fasttime.org>
@JamesHenry perhaps another Nx setup oddity?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🎉
Uh oh!
There was an error while loading.Please reload this page.
JoshuaKGoldberg commentedOct 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Build failures look to be some kind of Nx dependency shenanigan. I don't reproduce them locally.
Edit: like the last batch, these went away after merging from |
740a63f
intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
Makes the package public instead of private. Two changes are made to the package to support public use:
prettier
is removed. Consumers will be expected to format using their own formatter.compile()
to the more specificschemaToTypes()
.Also adds a docs page under
/packages/rule-schema-to-typescript-types
with a code sample and auto-generated docs for the one function.The snapshot file differences are due to the
prettier
formatting being moved out ofcompile
/schemaToTypes
. Formatting previously was only done in some cases inside the function. Now it's always done in the consumingschemas.test.ts
.Co-authored-by:@fasttime
💖