typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(ast-spec): cleanup`TSLiteralType`#11624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 4 commits intotypescript-eslint:mainfromabrahamguo:cleanup-tsliteraltype

Oct 7, 2025

Merged

fix(ast-spec): cleanup`TSLiteralType`#11624

bradzacher merged 4 commits intotypescript-eslint:mainfromabrahamguo:cleanup-tsliteraltype

Oct 7, 2025

+36 −5

Conversation

Copy link

Contributor

abrahamguo commentedSep 22, 2025

PR Checklist

Addresses an existing open issue:fixesEnhancement(AST): CleanupTSLiteralType #11587
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

From@bradzacher's proposal in#11587:

RemoveUpdateExpression from the type
Refine theLiteral union to just the valid literals
Refine theUnaryExpression to just the valid operators

clean up tsliteraltype

9b25a8e

Copy link

Contributor

typescript-eslintbot commentedSep 22, 2025

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 22, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4dd2118`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68d8469963283c00083dce19
😎 Deploy Preview	https://deploy-preview-11624--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 22, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit4dd2118

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 14s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 52s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	3s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run types:build`	✅ Succeeded	9s	View ↗
`nx run generate-configs`	✅ Succeeded	11s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-27 20:25:30 UTC

abrahamguo changed the title~~enhancement(ast): cleanupTSLiteralType~~fix(ast): cleanupTSLiteralType

Sep 22, 2025

abrahamguo changed the title~~fix(ast): cleanupTSLiteralType~~fix(ast-spec): cleanupTSLiteralType

Sep 22, 2025

abrahamguo changed the title~~fix(ast-spec): cleanupTSLiteralType~~fix(ast-spec): cleanupTSLiteralType

Sep 22, 2025

JoshuaKGoldberg reviewed

Sep 22, 2025

View reviewed changes

packages/ast-spec/src/type/TSLiteralType/spec.ts OutdatedShow resolvedHide resolved

Merge branch 'main' into cleanup-tsliteraltype

fb6f5b6

Copy link

codecovbot commentedSep 26, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (c1f891d) to head (4dd2118).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11624   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51370    51370             Branches     8476     8476           =======================================  Hits        46711    46711             Misses       4646     4646             Partials       13       13

Flag	Coverage Δ
unittest	`90.93% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.