Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions#11614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfrommdm317:fix-11581
Sep 29, 2025

Conversation

mdm317
Copy link
Contributor

PR Checklist

Overview

Report this case when ignoreBooleanCoercion is true:

declare const a: string | true | undefined;declare const b: string | boolean | undefined;const x = Boolean(a ? a : b);

but do not report this case:

declare const a: string | true | undefined;declare const b: string | boolean | undefined;declare const c: string | boolean | undefined;const x = Boolean(c || (a ? a : b));

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 18, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2654b6b
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68d2b531051196000861a207
😎 Deploy Previewhttps://deploy-preview-11614--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 18, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2654b6b

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 22sView ↗
nx run-many -t lint✅ Succeeded3m 16sView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded6sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
nx run generate-configs✅ Succeeded7sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-23 15:13:05 UTC

@codecovCodecov
Copy link

codecovbot commentedSep 18, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (c198052) to head (2654b6b).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11614   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51370    51373    +3       Branches     8476     8478    +2     =======================================+ Hits        46711    46714    +3  Misses       4646     4646             Partials       13       13
FlagCoverage Δ
unittest90.93% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts98.27% <100.00%> (+<0.01%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdm317mdm317 marked this pull request as ready for reviewSeptember 23, 2025 15:13
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks! 🚀

@JoshuaKGoldbergJoshuaKGoldberg merged commit967764e intotypescript-eslint:mainSep 29, 2025
62 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 30, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 || npm        | @typescript-eslint/parser        | 8.44.1 | 8.45.0 |## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 30, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 || npm        | @typescript-eslint/parser        | 8.44.1 | 8.45.0 |## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull requestOct 1, 2025
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestOct 1, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 || npm        | @typescript-eslint/parser        | 8.44.1 | 8.45.0 |## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestOct 3, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 || npm        | @typescript-eslint/parser        | 8.44.1 | 8.45.0 |## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to ternary expressions
2 participants
@mdm317@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp