This PR addresses#11609 and adjustsawait-thenable to allow passing values which may be promises to promise aggregator methods, specifically in an array literal:

declareconstmaybePromise:Promise<number>|number;Promise.all([maybePromise,Promise.resolve(1),Promise.resolve(2),Promise.resolve(3),]);

Note that this special cases array literals, and the code below will still be reported:

declareconstmaybePromise:Promise<number>|number;constarr=[maybePromise,Promise.resolve(1),Promise.resolve(2),Promise.resolve(3),];// Unexpected iterable of non-Promise (non-"Thenable") values passed to promise aggregator.Promise.all(arr);

fix: do not report values that may be a promise in an array literal

3f24615

Copy link

Contributor

typescript-eslintbot commentedSep 16, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

ronami marked this pull request as draft

September 16, 2025 21:20

Copy link

netlifybot commentedSep 16, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3f24615`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68c9d49ff9da46000884b4b7
😎 Deploy Preview	https://deploy-preview-11611--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 12 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 16, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3f24615

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 4s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 15s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 3s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	4s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-16 21:32:42 UTC

ronami changed the title~~fix(eslint-plugin):await-thenable should not report passing values to promise aggregators which may be a promise in an array literal~~fix(eslint-plugin): [await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal

Sep 16, 2025

Copy link

codecovbot commentedSep 16, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (2f0c6ac) to head (3f24615).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11611   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51332    51344   +12       Branches     8473     8474    +1     =======================================+ Hits        46677    46689   +12  Misses       4642     4642             Partials       13       13

Flag	Coverage Δ
unittest	`90.93% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/await-thenable.ts	`98.81% <100.00%> (+0.05%)`	⬆️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ronami marked this pull request as ready for review

September 16, 2025 21:39

JoshuaKGoldberg approved these changes

Sep 22, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense, +1 to this straightforward fix.

I'll go ahead and merge this a day ahead of our normal waiting period to get it into the release today.

JoshuaKGoldberg merged commitc392a0d intotypescript-eslint:main

Sep 22, 2025

70 of 72 checks passed

ronami deleted the await-thenable-maybe-promise branch

September 22, 2025 17:18

chrisbbreuer mentioned this pull request

Sep 22, 2025

chore(deps): update all non-major dependenciesstacksjs/eslint-plugin#64

Closed

ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull request

Sep 22, 2025

Porttypescript-eslint/typescript-eslint#11611

d402644

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 23, 2025

Update typescript-eslint monorepo to v8.44.1

33cea06

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm        | @typescript-eslint/parser        | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

thgreasi added a commit to balena-io/balena-sdk that referenced this pull request

Sep 24, 2025

Remove no longer needed eslint-disable @typescript-eslint/await

9b74f86

Change-type: patchtypescript-eslint/typescript-eslint#11609See:typescript-eslint/typescript-eslint#11611

thgreasi mentioned this pull request

Sep 24, 2025

Remove no longer needed eslint-disable @typescript-eslint/awaitbalena-io/balena-sdk#1571

Merged

4 tasks

thgreasi added a commit to balena-io/balena-sdk that referenced this pull request

Sep 24, 2025

Remove no longer needed eslint-disable @typescript-eslint/await

91d81e9

Change-type: patchSee:typescript-eslint/typescript-eslint#11609See:typescript-eslint/typescript-eslint#11611

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 25, 2025

Update typescript-eslint monorepo to v8.44.1

e7be0a8

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm        | @typescript-eslint/parser        | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 26, 2025

Update typescript-eslint monorepo to v8.44.1

731e799

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm        | @typescript-eslint/parser        | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 27, 2025

Update typescript-eslint monorepo to v8.44.1

5f34178

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm        | @typescript-eslint/parser        | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

fossabotbot mentioned this pull request

Sep 29, 2025

Bump @typescript-eslint/eslint-plugin from 8.42.0 to 8.44.1fossas/fossa-action#210

Merged

chrisbbreuer mentioned this pull request

Oct 4, 2025

chore(deps): update all non-major dependenciesstacksjs/eslint-plugin#67

Open

This was referencedOct 6, 2025

chore(deps-dev): bump the dependencies group with 4 updatesopenfga/js-sdk#263

Merged

Bump @typescript-eslint/eslint-plugin from 8.44.1 to 8.46.0fossas/fossa-action#220

Merged

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal#11611

fix(eslint-plugin): [await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal#11611

Uh oh!

Conversation

ronami commentedSep 16, 2025•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedSep 16, 2025

Uh oh!

netlifybot commentedSep 16, 2025•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedSep 16, 2025•
edited
Loading

Uh oh!

Uh oh!

codecovbot commentedSep 16, 2025•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal#11611

fix(eslint-plugin): [await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal#11611

Uh oh!

Conversation

ronami commentedSep 16, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedSep 16, 2025

Uh oh!

netlifybot commentedSep 16, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedSep 16, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedSep 16, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ronami commentedSep 16, 2025•
edited
Loading

netlifybot commentedSep 16, 2025•
edited
Loading

nx-cloudbot commentedSep 16, 2025•
edited
Loading

codecovbot commentedSep 16, 2025•
edited
Loading