Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-deprecated] prevent infinite loop on alias cy…#11605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
mainframev wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
frommainframev:fix/no-deprecated-perf-issue

Conversation

mainframev
Copy link
Contributor

@mainframevmainframev commentedSep 15, 2025•
edited
Loading

PR Checklist

Overview

This is a follow-up on#11197. The fix was originally implemented in#11359, but was inadvertently overwritten duringconflict resolution and never made it into the release. We have apatch in our codebase with this change. Without this fix, our lint task enters an infinite loop both locally and on CI

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mainframev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 15, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit73c5e51
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68c950b3d416340008b88670
😎 Deploy Previewhttps://deploy-preview-11605--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 15, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit73c5e51

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 10sView ↗
nx run-many -t lint✅ Succeeded3m 10sView ↗
nx run-many -t typecheck✅ Succeeded2m 5sView ↗
nx run integration-tests:test✅ Succeeded7sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded6sView ↗
nx run generate-configs✅ Succeeded9sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-16 12:09:51 UTC

@mainframev
Copy link
ContributorAuthor

@JoshuaKGoldberg 👋🏻

In my previous PR, I accidentally overwrote an important change and only noticed after it was merged. Should I open a separate issue to track this?

@codecovCodecov
Copy link

codecovbot commentedSep 15, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is80.00000% with3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.91%. Comparing base (85d8dea) to head (73c5e51).
⚠️ Report is 5 commits behind head on main.

Files with missing linesPatch %Lines
packages/eslint-plugin/src/rules/no-deprecated.ts80.00%3 Missing⚠️

❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11605      +/-   ##==========================================- Coverage   90.92%   90.91%   -0.01%==========================================  Files         506      506                Lines       51325    51345      +20       Branches     8469     8474       +5     ==========================================+ Hits        46665    46682      +17- Misses       4647     4650       +3  Partials       13       13
FlagCoverage Δ
unittest90.91% <80.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts96.36% <80.00%> (-0.79%)⬇️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mainframevmainframevforce-pushed thefix/no-deprecated-perf-issue branch from7b612eb to7dee4dcCompareSeptember 15, 2025 17:16
@mainframevmainframevforce-pushed thefix/no-deprecated-perf-issue branch from7dee4dc to73c5e51CompareSeptember 16, 2025 11:57
@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg 👋🏻

In my previous PR, I accidentally overwrote an important change and only noticed after it was merged. Should I open a separate issue to track this?

If you don't mind, yes please! We don't often look at draft PRs. I'll go ahead and review this one now in the meantime.

letcurrent=symbol;

while(tsutils.isSymbolFlagSet(current,ts.SymbolFlags.Alias)){
/* istanbul ignore next */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This'll need to be unit tested.

(I'm guessing you know this as a repeat contributor 😄 but just noting for tracking / in case someone else picks up this work)

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mainframev@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp