Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [no-unsafe-enum-comparison] support unions of literals#11599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:support-unions-in-nuecSep 22, 2025
Merged
fix(eslint-plugin): [no-unsafe-enum-comparison] support unions of literals#11599
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:support-unions-in-nuecSep 22, 2025
+98 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for the PR,@kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedSep 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedSep 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commite74b701
☁️Nx Cloud last updated this comment at |
codecovbot commentedSep 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Pleaseupload reports for the commite74b701 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@## main #11599 +/- ##======================================= Coverage 90.90% 90.90% ======================================= Files 505 505 Lines 51208 51218 +10 Branches 8441 8444 +3 =======================================+ Hits 46551 46561 +10 Misses 4644 4644 Partials 13 13
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg approved these changesSep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👌 nice.
20c3d97 intotypescript-eslint:main 61 checks passed
Uh oh!
There was an error while loading.Please reload this page.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 23, 2025
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 25, 2025
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 26, 2025
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 27, 2025
| datasource | package | from | to || ---------- | -------------------------------- | ------ | ------ || npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 || npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 |## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bugSomething isn't working
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
The problem was not about which type was the switch argument and which was the case, and more so about the fact that the rule didn't consider unions of number literals to be numbers (and ditto for strings).