Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-unused-private-class-members] new extension rule#11598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Zamiell
Copy link
Contributor

@ZamiellZamiell commentedSep 12, 2025•
edited
Loading

PR Checklist

Overview

  • First I copied the base rule from ESLint.
  • Next, I converted it to TypeScript + made it pass the linter + ensured that all tests were still passing.
  • Then, I refactored the main logic into a separate function called processPrivateIdentifier such that it could be called from different kinds of nodes.
  • Then, I added thePropertyDefinition selector.
  • Finally, I added some basic tests. Since the logic is directly reused from the base rule, more Typescript-specific tests are probably superfluous.

(This is my 2nd attempt at this PR, the first one was here:#10265)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 12, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitff0496f
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68c487437d27b400085ed36f
😎 Deploy Previewhttps://deploy-preview-11598--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 91 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@ZamiellZamiell changed the titleno unused private class membersfeat(eslint-plugin): [no-unused-private-class-members] new extension ruleSep 12, 2025
@ZamiellZamiellforce-pushed theno-unused-private-class-members branch from826da83 toa33465dCompareSeptember 12, 2025 20:28
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 12, 2025•
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.

View yourCI Pipeline Execution ↗ for commitff0496f

CommandStatusDurationResult
nx test eslint-plugin --coverage=false❌ Failed5m 11sView ↗
nx test eslint-plugin❌ Failed4m 51sView ↗
nx run-many -t lint✅ Succeeded3m 9sView ↗
nx run-many -t typecheck✅ Succeeded2m 9sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-12 20:57:23 UTC

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commentedSep 12, 2025•
edited
Loading

FYI@Zamiell before you put too much time into this, there is also#10913 which I think is pretty far along

@Zamiell
Copy link
ContributorAuthor

Oh nice, I didn't see that. Thank you Kirk, I'll close this now.

kirkwaiblinger reacted with thumbs up emoji

@ZamiellZamiell deleted the no-unused-private-class-members branchSeptember 12, 2025 20:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: no-unused-private-class-members
2 participants
@Zamiell@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp