typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore(typescript-estree): simplify`convertImportAttributes`#11594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 3 commits intotypescript-eslint:mainfromfisker:convertImportAttributes

Sep 16, 2025

Merged

chore(typescript-estree): simplify`convertImportAttributes`#11594

kirkwaiblinger merged 3 commits intotypescript-eslint:mainfromfisker:convertImportAttributes

Sep 16, 2025

Conversation

Copy link

Contributor

fisker commentedSep 11, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

chore(typescript-estree): simplifyconvertImportAttributes

9b36aa4

Copy link

Contributor

typescript-eslintbot commentedSep 11, 2025

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 11, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`03acd62`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68c9745e27efd00008f76f74
😎 Deploy Preview	https://deploy-preview-11594--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🟢 up 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 11, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit03acd62

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 9s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 16s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 58s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	21s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	11s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-16 14:41:27 UTC

Copy link

codecovbot commentedSep 11, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is57.14286% with3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.93%. Comparing base (77056f7) to head (03acd62).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	57.14%	3 Missing⚠️

❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11594   +/-   ##=======================================  Coverage   90.92%   90.93%           =======================================  Files         506      506             Lines       51338    51332    -6       Branches     8473     8473           =======================================- Hits        46678    46677    -1+ Misses       4647     4642    -5  Partials       13       13

Flag	Coverage Δ
unittest	`90.93% <57.14%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/convert.ts	`30.35% <57.14%> (+0.02%)`	⬆️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg previously approved these changes

Sep 15, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

packages/typescript-estree/src/convert.ts Outdated

Comment on lines 801 to 803

		constattritbutes=node.attributes??node.assertClause;
		return(
		attritbutes?.elements.map(element=>this.convertChild(element))??[]

Copy link

Member

JoshuaKGoldbergSep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	constattritbutes=node.attributes??node.assertClause;
	return(
	attritbutes?.elements.map(element=>this.convertChild(element))??[]
	constattributes=node.attributes??node.assertClause;
	return(
	attributes?.elements.map(element=>this.convertChild(element))??[]