Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(typescript-estree): addConverter#convertChildren()#11592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fisker
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 10, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commiteae0bed
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68cbee5b6cc2e10007e9b764
😎 Deploy Previewhttps://deploy-preview-11592--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 72 (🔴 down 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedSep 10, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commiteae0bed

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 7sView ↗
nx run-many -t lint✅ Succeeded3m 10sView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded22sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-18 11:47:15 UTC

@fiskerfisker changed the titlerefactor(typescript-estree): addConverter#covertChildren()chore(typescript-estree): addConverter#covertChildren()Sep 10, 2025
@fiskerfisker marked this pull request as ready for reviewSeptember 10, 2025 23:31
@codecov
Copy link

codecovbot commentedSep 11, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is53.19149% with22 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.93%. Comparing base (2f0c6ac) to head (eae0bed).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts53.19%22 Missing⚠️

❌ Your patch status has failed because the patch coverage (53.19%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11592   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51332    51323    -9       Branches     8473     8461   -12     =======================================- Hits        46677    46672    -5+ Misses       4642     4638    -4  Partials       13       13
FlagCoverage Δ
unittest90.93% <53.19%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/convert.ts30.28% <53.19%> (-0.08%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 15, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The -3 net line change is a nice touch 🙂 +1 from me.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 15, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just minor touchups requested

@JoshuaKGoldbergJoshuaKGoldberg removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 16, 2025
# Conflicts:#packages/typescript-estree/src/convert.ts
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 20, 2025
@kirkwaiblingerkirkwaiblinger changed the titlechore(typescript-estree): addConverter#covertChildren()chore(typescript-estree): addConverter#convertChildren()Sep 20, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit328a96d intotypescript-eslint:mainSep 22, 2025
65 of 66 checks passed
@fiskerfisker deleted the convert-children branchSeptember 22, 2025 14:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fisker@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp