typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore: remove unnecessary nullThrows()#11580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:remove-unnecessary-null-throws

Sep 12, 2025

Merged

chore: remove unnecessary nullThrows()#11580

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:remove-unnecessary-null-throws

Sep 12, 2025

Conversation

Copy link

Member

kirkwaiblinger commentedSep 8, 2025

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

yayNodeWithParent!

chore: remove unnecessary nullThrows()

f74665b

Copy link

Contributor

typescript-eslintbot commentedSep 8, 2025

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 8, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9ce2332`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68c497dea3f97000088013ab
😎 Deploy Preview	https://deploy-preview-11580--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 10 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 8, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit9ce2332

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4m 58s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 18s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	5s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-12 22:12:31 UTC

Copy link

codecovbot commentedSep 8, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (95c7287) to head (9ce2332).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11580      +/-   ##==========================================- Coverage   90.90%   90.90%   -0.01%==========================================  Files         505      505                Lines       51208    51197      -11       Branches     8441     8441              ==========================================- Hits        46551    46540      -11  Misses       4644     4644                Partials       13       13

Flag	Coverage Δ
unittest	`90.90% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...plugin/src/rules/prefer-string-starts-ends-with.ts	`98.82% <100.00%> (-0.01%)`	⬇️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts	`99.03% <100.00%> (-0.04%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.