Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): disallow empty type parameter/argument lists#11563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Also removes a few now-unnecessary tests and logic in some rules

fisker reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf8c76dd
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68b68ac72a23cd0008e13842
😎 Deploy Previewhttps://deploy-preview-11563--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf8c76dd

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 20sView ↗
nx run-many -t lint✅ Succeeded3m 21sView ↗
nx run-many -t typecheck✅ Succeeded2m 8sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded11sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run types:build✅ Succeeded6sView ↗
nx run generate-configs✅ Succeeded10sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-02 06:23:14 UTC

@codecovCodecov
Copy link

codecovbot commentedSep 1, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is35.71429% with9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (0daf303) to head (f8c76dd).
⚠️ Report is 27 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts30.76%9 Missing⚠️

❌ Your patch status has failed because the patch coverage (35.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11563      +/-   ##==========================================- Coverage   90.90%   90.88%   -0.02%==========================================  Files         505      505                Lines       51121    51130       +9       Branches     8417     8419       +2     ==========================================- Hits        46469    46468       -1- Misses       4639     4649      +10  Partials       13       13
FlagCoverage Δ
unittest90.88% <35.71%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/array-type.ts98.79% <100.00%> (-0.81%)⬇️
packages/typescript-estree/src/convert.ts30.33% <30.76%> (-0.06%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewSeptember 1, 2025 15:35
TSError
2 |
3 | class foo {
> 4 | constructor<>() {}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This one's weird because it's also illegal to have type parameters on aconstructor(); they have to be on theclass foo<...>.

Josh-Cena
Josh-Cena previously approved these changesSep 2, 2025
Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just one nit but consider myself happy with this

kirkwaiblinger reacted with thumbs up emoji
@kirkwaiblingerkirkwaiblinger added the ASTPRs and Issues about the AST structure labelSep 2, 2025
@JamesHenry
Copy link
Member

@kirkwaiblinger temp testing workflows sorry for the noise

kirkwaiblinger reacted with thumbs up emoji

@JamesHenryJamesHenry changed the titlefeat(typescript-estree): disallow empty type parameter/argument listsfeat(typescript-estree)!: disallow empty type parameter/argument listsSep 3, 2025
@JamesHenryJamesHenry changed the titlefeat(typescript-estree)!: disallow empty type parameter/argument listsfeat(typescript-estree): disallow empty type parameter/argument listsSep 3, 2025
@JamesHenryJamesHenry changed the titlefeat(typescript-estree): disallow empty type parameter/argument listsfeat(typescript-estree)!: disallow empty type parameter/argument listsSep 3, 2025
@JamesHenryJamesHenry changed the titlefeat(typescript-estree)!: disallow empty type parameter/argument listsfeat(typescript-estree): disallow empty type parameter/argument listsSep 3, 2025
@JamesHenry
Copy link
Member

@kirkwaiblinger all good

kirkwaiblinger reacted with thumbs up emoji

@JoshuaKGoldbergJoshuaKGoldberg merged commit4f44a6e intotypescript-eslint:mainSep 8, 2025
74 of 77 checks passed
@kirkwaiblingerkirkwaiblinger deleted the disallow-empty-type-argument-list branchSeptember 8, 2025 14:37
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 10, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Josh-CenaJosh-CenaAwaiting requested review from Josh-Cena

Assignees
No one assigned
Labels
ASTPRs and Issues about the AST structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Forbid empty type argument list
4 participants
@kirkwaiblinger@JamesHenry@Josh-Cena@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp