typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(typescript-eslint): handle non-normalized windows paths produced by jiti#11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:handle-forward-slash-windows-paths

Sep 1, 2025

Merged

fix(typescript-eslint): handle non-normalized windows paths produced by jiti#11546

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:handle-forward-slash-windows-paths

Sep 1, 2025

Conversation

Copy link

Member

kirkwaiblinger commentedSep 1, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: (Windows) Parsing error: inferred tsconfigRootDir should be a resolved absolute path, but received: "C:/Users/29422/Desktop/vue-project". #11530
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Since Jiti gives paths asC:/path/to/file in the stack trace on windows, we convert it toC:\path\to\file before validating.

Verified by local linking that this does solve the repro inBug: (Windows) Parsing error: inferred tsconfigRootDir should be a resolved absolute path, but received: "C:/Users/29422/Desktop/vue-project". #11530
Added lines are tested, but windows only, hence the coverage failure

add workaround

80cde78

Copy link

Contributor

typescript-eslintbot commentedSep 1, 2025

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`7728c21`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68b59c51176ffd0008d1a19f
😎 Deploy Preview	https://deploy-preview-11546--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🔴 down 1 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedSep 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit7728c21

Command	Status	Duration	Result
`nx run-many -t typecheck`	✅ Succeeded	2m 12s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 18s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-01 13:24:09 UTC

Copy link

codecovbot commentedSep 1, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is0% with3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (ee3efa7) to head (7728c21).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...pescript-eslint/src/getTSConfigRootDirFromStack.ts	0.00%	3 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11546      +/-   ##==========================================- Coverage   90.84%   90.84%   -0.01%==========================================  Files         505      505                Lines       51167    51170       +3       Branches     8422     8423       +1     ==========================================  Hits        46485    46485- Misses       4668     4671       +3  Partials       14       14

Flag	Coverage Δ
unittest	`90.84% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...pescript-eslint/src/getTSConfigRootDirFromStack.ts	`90.90% <0.00%> (-9.10%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.