Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [prefer-optional-chain] include mixed "nullish comparison style" chains in checks#11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mdm317
Copy link
Contributor

@mdm317mdm317 commentedAug 27, 2025•
edited
Loading

PR Checklist

Overview

"boolean" checks (eg foo and !foo)
!==/===/!=/== comparing against anything except typeof
not typeof because foo && typeof foo.bar will return undefined | typeof foo.bar whereas typeof foo?.bar will return typeof foo.bar | 'undefined' - which is VERY different
should not include >/>=/</<= because TS will hard error if one of the operands is nullish.

In this PR, I decided not to include boolean checks within optional chaining.
The reason is that the boolean outcome may differ between the original code and the optional chaining, which may lead to type inference issues (for example, as described inissue 7654

foo && !foo.barif( foo && !foo.bar ){// foo can't nullish}if( !foo?.bar ){// foo can nullisth}

So I only handle equality operators (==, ===, !=, !==) at the end of a chain, and only when the boolean result is unchanged after converting to optional chaining.

Algorithm
AND (&&) versions

ExpressionLHS (a != null && …)RHS (a?.b …)Equal if…
a != null && a.b != somevalue ↔ a?.b != somevaluefalseundefined != somevaluesomevalue == null (null orundefined)
a != null && a.b !== somevalue ↔ a?.b !== somevaluefalseundefined !== somevaluesomevalue === undefined
a != null && a.b == somevalue ↔ a?.b == somevaluefalseundefined == somevaluesomevalue != null
a != null && a.b === somevalue ↔ a?.b === somevaluefalseundefined === somevaluesomevalue !== undefined

OR (||) versions

ExpressionLHS (a == null || …)RHS (a?.b …)Equal if…
a == null |\ a.b != somevalue ↔ a?.b != somevaluetrueundefined != somevaluesomevalue != null
a == null || a.b !== somevalue ↔ a?.b !== somevaluetrueundefined !== somevaluesomevalue !== undefined
a == null || a.b == somevalue ↔ a?.b == somevaluetrueundefined == somevaluesomevalue == null
a == null || a.b === somevalue ↔ a?.b === somevaluetrueundefined === somevaluesomevalue === undefined

Test cases

Valid (no report)

Wedo not report when converting to optional chaining could change runtime behavior — especially with truthy/falsy values.
Example fromissue 7654:

constdata:Data|null=getData();// Both: `data` must be truthy AND `data.value` not null (0 is valid)if(data&&data.value!==null){console.log("Number: "+data.value);}else{console.log("Invalid data.");}

Error

Conversion to optional chaining either produces the same result as before, or introduces a type allowed by optional chaining.

foo != null && foo.barfoo?.bar

Suggestion

Optional chaining introduces an additional undefined type, which changes the result type but preserves the same truthy/falsy behavior.

declare const foo: { bar: number } | null | undefined;foo != undefined && foo.bar;         => false | numberfoo?.bar                                           => undefined | number

Currently, even when the type changes, especially truthy and false some cases report as a suggestion.
examples

declare const foo : { bar : number | null } | nullfoo == null || foo.bar === null    => true when foo is nullfoo?.bar === null                         => false when foo is null

I think we should fix these cases not to be reported as suggestions.
repro

…perator consistency based on logical operator- When parent operator is `&&`, enforce `==` or `===` as the last operand operator.- When parent operator is `||`, enforce `!=` or `!==` as the last operand operator.
 - Already check isTruthyOperand and isValidLastChainOperand so dowmstream error not occur when ComparisonType - And !==, != check not  nullish
some occur in chain when != null is last chaintypescript-eslint#7654
a != null && a.b != nulla?.b != nullalways same when a != null is true
a !== undefined && a.ba?.balways same when a is not nullish
a || b  isalways b when a is false
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedAug 27, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf8e07cf
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68dfc31c2d4ed3000800114c
😎 Deploy Previewhttps://deploy-preview-11533--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 21 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedAug 27, 2025•
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.

View yourCI Pipeline Execution ↗ for commitf8e07cf

CommandStatusDurationResult
nx run-many -t typecheck❌ Failed2m 2sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 13sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
nx run generate-configs✅ Succeeded6sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded16sView ↗
Additional runs (28)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-10-03 12:48:53 UTC

@mdm317mdm317 marked this pull request as draftSeptember 4, 2025 09:02
@codecov
Copy link

codecovbot commentedSep 4, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.78%. Comparing base (cdd6384) to head (f8e07cf).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11533      +/-   ##==========================================+ Coverage   90.74%   90.78%   +0.04%==========================================  Files         516      516                Lines       51989    52222     +233       Branches     8588     8646      +58     ==========================================+ Hits        47176    47409     +233  Misses       4799     4799                Partials       14       14
FlagCoverage Δ
unittest90.78% <100.00%> (+0.04%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts99.06% <ø> (ø)
...ackages/eslint-plugin/src/rules/prefer-includes.ts98.16% <100.00%> (ø)
.../rules/prefer-optional-chain-utils/analyzeChain.ts100.00% <100.00%> (ø)
...efer-optional-chain-utils/gatherLogicalOperands.ts100.00% <100.00%> (ø)
...s/eslint-plugin/src/rules/prefer-optional-chain.ts100.00% <100.00%> (ø)
...plugin/src/rules/prefer-string-starts-ends-with.ts98.82% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +273 to 274
// eslint-disable-next-line @typescript-eslint/prefer-optional-chain
if(declarations==null||declarations.length!==1){
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

const declarations: ts.Declaration[] | undefined

When the new logic was applied, this code
declarations == null || declarations.length !== 1
was changed to
declarations?.length !== 1

But I think the original code is more readable and intuitive.
For cases likefoo == null || <equaliy check>, should we avoid optional chaining?
What do you think?
example new playground

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If the choices are these:

  • Original:if (declations == null || declations.length !== 1) {
  • Updated:if (declations?.length !== 1) {

Personal anecodtal thoughts: I find the updated form more readable. I think when?. was new I would probably have preferred the original for being more familiar. But at this point I'm pretty comfortable with?. and??, and it feels natural to me.

mdm317 reacted with thumbs up emoji
returnfalse;
}

functionisAlwaysTruthyOperand(
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not convinced this function is necessary.
This function checks if the previous operand is always true:

  • foo != null && foo.bar == somevalue →foo?.bar == somevalue (same result when foo is not nullish)
  • foo && foo.bar == somevalue →foo?.bar == somevalue (same result when foo is truthy)

But if we knowfoo is not nullish, we can simply writefoo.bar == somevalue without optional chaining at all.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergOct 3, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removing it fails some unit tests (that have legitimate cases, I believe). E.g.:

declareconstfoo:{bar:string}|null;foo!==null&&foo.bar!==null;

mdm317 reacted with thumbs up emoji
chain,
)=>{
switch(operand.comparisonType){
caseNullishComparisonType.Boolean:{
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This logic moved to line 700.

JoshuaKGoldberg reacted with thumbs up emoji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for these tips, they made reviewing this (already, by necessity, complex) logic easier. 🙂

mdm317 reacted with thumbs up emoji
Comment on lines +713 to +714
caseNullishComparisonType.StrictEqualNull:
caseNullishComparisonType.NotStrictEqualNull:{
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When the last parameter is StrictEqualNull likefoo && foo.bar !== null, we can't convert to optional chaining because:

  • foo && foo.bar !== null returnsfalse when foo is nullish
  • foo?.bar !== null returnstrue when foo is nullish

Also StrictEqualNull case foo == null | foo.bar !== null

  • foo == null || foo.bar !== null returnstrue when foo is nullish
  • foo?.bar !== null returnsfalse when foo is nullish

This issue is documentedhere.

But as I mentioned above, I'm still curious whether this logic is necessary at all.

lastOperand.comparisonType,
parserServices,
)||
isValidLastChainOperand(
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This function checks if the last operand is valid as outlined in the table.

JoshuaKGoldberg reacted with thumbs up emoji
left.type===AST_NODE_TYPES.MemberExpression;
constisRightMemberExpression=
right.type===AST_NODE_TYPES.MemberExpression;
if(isLeftMemberExpression&&!isRightMemberExpression){
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Only checks MemberExpression because equality checks cannot be the first chain element.

JoshuaKGoldberg reacted with thumbs up emoji
| null
| undefined;
};
foo.bar?.() !== null &&
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Iffoo.bar is guaranteed to be non-nullish, we can change it to optional chaining.

JoshuaKGoldberg reacted with thumbs up emoji
| undefined;
};
foo.bar === undefined ||
foo.bar() === undefined ||
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sinceoperand is a nullish check,
operand || foo.bar() === undefined can be converted to optional chaining.

JoshuaKGoldberg reacted with thumbs up emoji
@mdm317mdm317 marked this pull request as ready for reviewSeptember 8, 2025 04:43
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have to be honest, this rule is one of my least favorites to review -- purely because of how intricate and nuanced its logic is. Each time I review I think I get to maybe 80% comprehension of it. Very Pareto Principle. If someone like@bradzacher has time to take a deeper look that'd probably be best... but the ruleis quite well-tested, and from what I had time to parse out this is excellent.

I have no suggestions for changes. Just the one request to remove aneslint-disable internally as you'd brought a comment up on.

Awesome work. Really, thank you for diving so much into this beast of a rule! 🔥

mdm317 reacted with heart emoji
Comment on lines +273 to 274
// eslint-disable-next-line @typescript-eslint/prefer-optional-chain
if(declarations==null||declarations.length!==1){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If the choices are these:

  • Original:if (declations == null || declations.length !== 1) {
  • Updated:if (declations?.length !== 1) {

Personal anecodtal thoughts: I find the updated form more readable. I think when?. was new I would probably have preferred the original for being more familiar. But at this point I'm pretty comfortable with?. and??, and it feels natural to me.

mdm317 reacted with thumbs up emoji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] Such thorough testing! Lovely. 👏 🔥

mdm317 reacted with heart emoji
// x == something :(
// x === something :(
// x != something :(
// x !== something :(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] The:(s made me chuckle. 😄

mdm317 reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 3, 2025
@bradzacherbradzacher merged commit73003bf intotypescript-eslint:mainOct 7, 2025
65 of 67 checks passed
@B4nan
Copy link

This PR is too aggressive and suggests optional chaining in cases where it would change behavior.

Few cases frommikro-orm/mikro-orm#6924 (when applying the suggested fixes, the better half of the test suite breaks).

-    if (meta.properties[propertyName] && meta.properties[propertyName].kind !== reference) {+    if (meta.properties[propertyName]?.kind !== reference) {
-    if (!meta.embeddable && (!meta.primaryKeys || meta.primaryKeys.length === 0)) {+    if (!meta.embeddable && (meta.primaryKeys?.length === 0)) {
-      if (!prop.ownColumns || prop.ownColumns.length === 0) {+      if (prop.ownColumns?.length === 0) {
-    if (!last || last[0] !== entityName || last[1] !== prop) {+    if (last?.[0] !== entityName || last[1] !== prop) {

Basically, all the changes that the PR suggests are wrong.

@kirkwaiblinger
Copy link
Member

@B4nan We ask that you please file a new issue rather than commenting on a closed PR, seehttps://typescript-eslint.io/contributing/issues#commenting.

I'm not able to reproduce what you're seeing in the playground based on my best guess at creating a reproduction... This code does not result in a lint report:

(playground)

declareconsta:{b?:number[]};if(!a.b||a.b.length===0){}

Can you please help us help you by creating an isolated reproduction we can try, and filing a new issue with it? Thanks!

@aboks
Copy link

We also observe overly 'aggresive' behavior from this rule, as described in the comment by@B4nan. I've opened#11700 with a reproduction case.

B4nan, mdm317, kirkwaiblinger, drake-nathan, and MathieuArn reacted with thumbs up emoji

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestOct 15, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.0 | 8.46.1 || npm        | @typescript-eslint/parser        | 8.46.0 | 8.46.1 |## [v8.46.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestOct 17, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.0 | 8.46.1 || npm        | @typescript-eslint/parser        | 8.46.0 | 8.46.1 |## [v8.46.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
ch4og pushed a commit to csmplay/mapban that referenced this pull requestNov 18, 2025
This PR contains the following updates:| Package | Change | Age | Confidence ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) || [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#&#8203;10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@&#8203;bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#&#8203;11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#&#8203;11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#&#8203;11006](typescript-eslint/typescript-eslint#11006), [#&#8203;10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- Kentaro Suzuki [@&#8203;sushichan044](https://github.com/sushichan044)- Maria Solano [@&#8203;MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#&#8203;11722](typescript-eslint/typescript-eslint#11722), [#&#8203;11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#&#8203;11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#&#8203;11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#&#8203;11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#&#8203;11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)##### 🚀 Features- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#&#8203;11659](typescript-eslint/typescript-eslint#11659))- **rule-schema-to-typescript-types:** clean up and make public ([#&#8203;11633](typescript-eslint/typescript-eslint#11633))##### 🩹 Fixes- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#&#8203;11660](typescript-eslint/typescript-eslint#11660))- **typescript-estree:** forbid abstract method and accessor to have implementation ([#&#8203;11657](typescript-eslint/typescript-eslint#11657))- **eslint-plugin:** removed error type previously deprecated ([#&#8203;11674](typescript-eslint/typescript-eslint#11674))- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#&#8203;11603](typescript-eslint/typescript-eslint#11603))- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#&#8203;11634](typescript-eslint/typescript-eslint#11634))- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#&#8203;11628](typescript-eslint/typescript-eslint#11628))- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#&#8203;11487](typescript-eslint/typescript-eslint#11487))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)- Josh Goldberg ✨- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- Mark de Dios [@&#8203;peanutenthusiast](https://github.com/peanutenthusiast)- Richard Torres [@&#8203;richardtorres314](https://github.com/richardtorres314)- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#&#8203;11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#&#8203;11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#&#8203;11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#&#8203;11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#&#8203;11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#&#8203;11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#&#8203;11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#&#8203;11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#&#8203;11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#&#8203;11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#&#8203;11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#&#8203;11423](typescript-eslint/typescript-eslint#11423), [#&#8203;11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#&#8203;11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#&#8203;11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#&#8203;11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#&#8203;11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#&#8203;11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@&#8203;dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@&#8203;mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)##### 🩹 Fixes- **deps:** update eslint monorepo to v9.33.0 ([#&#8203;11482](typescript-eslint/typescript-eslint#11482))You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)##### 🩹 Fixes- **deps:** update dependency prettier to v3.6.2 ([#&#8203;11496](typescript-eslint/typescript-eslint#11496))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)##### 🚀 Features- **typescript-estree:** forbid invalid keys in `EnumMember` ([#&#8203;11232](typescript-eslint/typescript-eslint#11232))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Reviewed-on:https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20Co-authored-by: Renovate Bot <renovate@csmpro.ru>Co-committed-by: Renovate Bot <renovate@csmpro.ru>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

6 participants

@mdm317@B4nan@kirkwaiblinger@aboks@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp