Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: deprecate tseslint.config()#11531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedAug 26, 2025
edited
Loading

Important

If you've come across this PR looking for info on migrating off oftseslint.config(), please seehttps://typescript-eslint.io/packages/typescript-eslint#migrating-to-defineconfig


PR Checklist

Overview

  • Replacestseslint.config() in the docs everywhere withdefineConfig()
  • adds/** @deprecated */ totseslint.config().
  • adds deprecation/migration info to the docs.
  • switches our eslint config to usedefineConfig()

Questions

  • Should we use thedefineConfig(a, b, c) ordefineConfig([a, b, c]) style? The eslint docs (inexplicably) usedefineConfig([a, b, c]) throughout, butdefineConfig(a, b, c) is much better in a TS context since each argument's type is checked individually. I've gone with that approach for now, but we can change to match their style if we want.

Shinigami92, fregante, and polyzen reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 26, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1576c1f
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68b52f48176ffd0008b877c8
😎 Deploy Previewhttps://deploy-preview-11531--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (🔴 down 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 26, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit1576c1f

CommandStatusDurationResult
nx run-many -t lint✅ Succeeded3m 28sView ↗
nx run-many -t typecheck✅ Succeeded2mView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded3sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-01 05:35:32 UTC

@kirkwaiblingerkirkwaiblinger changed the titledocs: deprecate tseslint.config()feat: deprecate tseslint.config()Aug 27, 2025
@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewAugust 27, 2025 17:28
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesAug 27, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Always nice to see a formatter issue filed as a result of docs work 😅

Great stuff!

kirkwaiblinger reacted with heart emoji
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

kirkwaiblinger reacted with heart emoji
@Josh-CenaJosh-Cena added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelAug 28, 2025
@kirkwaiblingerkirkwaiblingerenabled auto-merge (squash)September 1, 2025 05:29
@kirkwaiblingerkirkwaiblinger merged commitd7614a7 intotypescript-eslint:mainSep 1, 2025
63 checks passed
@kirkwaiblingerkirkwaiblinger deleted the deprecate-tseslint-config branchSeptember 1, 2025 15:22
@stefanprobst
Copy link

stefanprobst commentedSep 2, 2025
edited
Loading

is theConfigWithExtends type available publicly?

@corneliusroemer
Copy link

Migration guide for deprecatedtseslint.config() ->defineConfig:https://typescript-eslint.io/packages/typescript-eslint/#migrating-to-defineconfig

kirkwaiblinger reacted with thumbs up emoji

@kirkwaiblinger
Copy link
MemberAuthor

@stefanprobst

is theConfigWithExtends type available publicly?

This isn't directly related to this PR, and we anyways try to avoid commenting on closed PRs (docs). Would you mind reaching out to us with one of the methods in the contributing guide to continue the conversation?

Thanks!

@typescript-eslinttypescript-eslint locked asresolvedand limited conversation to collaboratorsSep 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Josh-CenaJosh-CenaJosh-Cena approved these changes

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mention defineConfig(); remove mention of tseslint.config()
5 participants
@kirkwaiblinger@stefanprobst@corneliusroemer@JoshuaKGoldberg@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp