typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(type-utils): add union type support to TypeOrValueSpecifier#11526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromy-hsgw:fix/type-or-value-specifier

Sep 3, 2025

Merged

fix(type-utils): add union type support to TypeOrValueSpecifier#11526

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromy-hsgw:fix/type-or-value-specifier

Sep 3, 2025

Conversation

Copy link

Contributor

y-hsgw commentedAug 24, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [only-throw-error] TypeOrValueSpecifier does not handle union #11452
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Add union type support to TypeOrValueSpecifier.

🐛

y-hsgw added2 commits

August 24, 2025 15:16

feat: enhance typeMatchesSpecifier to handle union types

208ca1d

test: add tests

61903a8

Copy link

Contributor

typescript-eslintbot commentedAug 24, 2025

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedAug 24, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0320f33`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68b0409d7a92c70009a297a7
😎 Deploy Preview	https://deploy-preview-11526--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (no change from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedAug 24, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit0320f33

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 4s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 22s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 3s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	9s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	9s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-08-28 11:54:37 UTC

Copy link

codecovbot commentedAug 24, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (bd9e490) to head (0320f33).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11526   +/-   ##=======================================  Coverage   90.87%   90.87%           =======================================  Files         505      505             Lines       51146    51149    +3       Branches     8424     8427    +3     =======================================+ Hits        46480    46483    +3  Misses       4652     4652             Partials       14       14

Flag	Coverage Δ
unittest	`90.87% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kirkwaiblinger reviewed

Aug 27, 2025

View reviewed changes

packages/type-utils/src/TypeOrValueSpecifier.ts Outdated

		program:ts.Program,
		):boolean{
		if(tsutils.isUnionType(type)){
		returntype.types.some(t=>typeMatchesSpecifier(t,specifier,program));

Copy link

Member

kirkwaiblingerAug 27, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this should have.every() semantics, no? That's both my intuition and what I take away from#11452 (comment)

Could you please also add a test that cements this behavior? (e.g. ensuring matchingPromise<A> | B should or should not be matched)

Copy link

ContributorAuthor

y-hsgwAug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're right, every is the correct approach.
My interpretation was off... 😂
I’ve fixed it inc878727.

kirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party label

Aug 27, 2025

y-hsgw added2 commits

August 28, 2025 18:32

fix: update typeMatchesSpecifier to require all union types to match

c878727

test: add tests

0320f33

y-hsgw requested a review fromkirkwaiblinger

August 28, 2025 11:45

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Aug 28, 2025

kirkwaiblinger approved these changes

Aug 29, 2025

View reviewed changes

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Aug 29, 2025

JoshuaKGoldberg approved these changes

Sep 3, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks! 🙌

JoshuaKGoldberg merged commit2ec83b9 intotypescript-eslint:main

Sep 3, 2025

64 of 65 checks passed

y-hsgw deleted the fix/type-or-value-specifier branch

September 3, 2025 11:27

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 10, 2025

Update typescript-eslint monorepo to v8.43.0

ea14311

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.