Paths like'./../../file.ts' were not being detected as escaping the current directory because the check only looked for paths starting with'..' . This fix normalizes paths before checking, so paths like'./../' and'./../../' are properly handled.

fix(rule-tester): normalize paths before checking if they escape cwd

3830861

Copy link

Contributor

typescript-eslintbot commentedAug 23, 2025

Thanks for the PR,@dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedAug 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`6ff0c5a`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68b0af658047ff00085892ce
😎 Deploy Preview	https://deploy-preview-11525--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (no change from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedAug 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit6ff0c5a

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 9s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 19s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	11s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	9s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-08-28 19:45:59 UTC

Copy link

ContributorAuthor

dbarabashh commentedAug 23, 2025

Not very sure if this is the same problem as in the previousPR. But it looks like it is coming from the main branch and needs to be fixed.@JoshuaKGoldberg,@kirkwaiblinger wdyt?

Merge branch 'main' into fix/rule-tester-normalize-paths

2247e46

Copy link

codecovbot commentedAug 27, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (31a7336) to head (6ff0c5a).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11525   +/-   ##=======================================  Coverage   90.87%   90.87%           =======================================  Files         505      505             Lines       51146    51146             Branches     8424     8424           =======================================  Hits        46480    46480             Misses       4652     4652             Partials       14       14

Flag	Coverage Δ
unittest	`90.87% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/rule-tester/src/RuleTester.ts	`73.78% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.