Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-type-conversion] only report ~~ on integer literal types#11517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mouse0429
Copy link
Contributor

PR Checklist

Overview

Modified the rule to only report ~~ as unnecessary when applied to integer literal types:

  • ~~5 → Reports as unnecessary ✅ (literal integer)
  • ~~(3 | 4) → Reports as unnecessary ✅ (union of integer literals)
  • ~~1.1 → No report ✅ (decimal literal - meaningful conversion)
  • ~~(2 + 2) → No report ✅ (expression - conservative approach)

injae-kim and skondrashov reacted with thumbs up emojiinjae-kim and skondrashov reacted with heart emojiinjae-kim and skondrashov reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mouse0429!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 20, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit35eb71c
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68b83968b582de0008419486
😎 Deploy Previewhttps://deploy-preview-11517--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 20, 2025•
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.

View yourCI Pipeline Execution ↗ for commit35eb71c

CommandStatusDurationResult
nx run-many -t typecheck❌ Failed2m 11sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 8sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded18sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-03 13:00:55 UTC

@codecovCodecov
Copy link

codecovbot commentedAug 20, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (f9975aa) to head (35eb71c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11517   +/-   ##=======================================  Coverage   90.90%   90.90%           =======================================  Files         505      505             Lines       51125    51158   +33       Branches     8421     8424    +3     =======================================+ Hits        46473    46506   +33  Misses       4639     4639             Partials       13       13
FlagCoverage Δ
unittest90.90% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...plugin/src/rules/no-unnecessary-type-conversion.ts100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks!

mouse0429 reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 3, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉🎉

mouse0429 reacted with heart emoji
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commentedSep 3, 2025•
edited
Loading

Hmm, CI has some odd failures after merging frommain.

packages/type-utils/src/TypeOrValueSpecifier.ts(2,34): error TS7016: Could not find a declaration file for module '@typescript-eslint/utils/json-schema'. '/home/runner/work/typescript-eslint/typescript-eslint/packages/utils/dist/json-schema.js' implicitly has an 'any' type....

They shouldn't be related to this PR. They don't happen locally for me. FYI@JamesHenry

@JoshuaKGoldbergJoshuaKGoldberg merged commitf0e64eb intotypescript-eslint:mainSep 3, 2025
60 of 63 checks passed
ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull requestSep 10, 2025
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 10, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-type-conversion] Unsafe suggestion: removing bitwise~~ changes semantics for non-integer numbers
3 participants
@mouse0429@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp