Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(typescript-estree): fix range of assignment in parameter#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JamesHenry merged 5 commits intotypescript-eslint:masterfromarmano2:property-assignment-patternJan 22, 2019
Merged
fix(typescript-estree): fix range of assignment in parameter#115
JamesHenry merged 5 commits intotypescript-eslint:masterfromarmano2:property-assignment-patternJan 22, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedJan 22, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #115 +/- ##==========================================+ Coverage 95% 95.01% +<.01%========================================== Files 48 48 Lines 2484 2487 +3 Branches 381 382 +1 ==========================================+ Hits 2360 2363 +3 Misses 75 75 Partials 49 49
|
JamesHenry approved these changesJan 22, 2019
armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull requestJan 24, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
bugSomething isn't working package: typescript-estreeIssues related to @typescript-eslint/typescript-estree
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with modifiers range beeing included into
AssignmentPatternin parameter propertymodifiers in this case are attached to
TSParameterProperty#114 (comment)