Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): forbid invalid keys inEnumMember#11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fisker
Copy link
Contributor

@fiskerfisker commentedAug 18, 2025•
edited by kirkwaiblinger
Loading

This reverts commit7648622.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedAug 18, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitfb5506b
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68b581e16ead44000734965d
😎 Deploy Previewhttps://deploy-preview-11497--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedAug 18, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitfb5506b

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 10sView ↗
nx run-many -t lint✅ Succeeded3m 20sView ↗
nx run-many -t typecheck✅ Succeeded2m 5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded11sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run types:build✅ Succeeded10sView ↗
nx run generate-configs✅ Succeeded12sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-01 11:33:37 UTC

@fisker
Copy link
ContributorAuthor

Looks like this is still an issue,#11232 (comment), any idea to fix it?

@fisker
Copy link
ContributorAuthor

I'm not sure what I did, but CI passes now.

@fiskerfisker marked this pull request as ready for reviewAugust 18, 2025 20:09
@codecov
Copy link

codecovbot commentedAug 18, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is68.29268% with13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (d7614a7) to head (fb5506b).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts65.78%13 Missing⚠️

❌ Your patch status has failed because the patch coverage (68.29%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11497      +/-   ##==========================================- Coverage   90.87%   90.84%   -0.03%==========================================  Files         505      505                Lines       51146    51167      +21       Branches     8424     8422       -2     ==========================================+ Hits        46480    46485       +5- Misses       4652     4668      +16  Partials       14       14
FlagCoverage Δ
unittest90.84% <68.29%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts97.79% <100.00%> (-0.02%)⬇️
...ackages/scope-manager/src/referencer/Referencer.ts97.93% <100.00%> (-0.01%)⬇️
packages/typescript-estree/src/convert.ts30.38% <65.78%> (+0.21%)⬆️

... and2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiskerfiskerforce-pushed therevert-11493-revert-11232 branch fromfe02b99 to2ac5502CompareAugust 23, 2025 13:18
constid=node.id;
TSEnumMember:{
handler:(node:TSESTree.TSEnumMember,validator):void=>{
// Unknown reason, can't get the correct type

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks like the problem with these types is that this PR is missing a corresponding change in packages/types/src/ts-estree.ts.

See

interfaceTSEnumMemberComputedName{
parent:TSESTree.TSEnumBody;
}
interfaceTSEnumMemberNonComputedName{
parent:TSESTree.TSEnumBody;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've pushedde0e9ff to clean them up 👍

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great! Thanks!

kirkwaiblinger reacted with thumbs up emoji
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelAug 27, 2025
@github-actionsgithub-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelAug 27, 2025
@kirkwaiblinger
Copy link
Member

kirkwaiblinger commentedAug 27, 2025•
edited
Loading

Approving in that

Will give@bradzacher a chance to double-check in case before merging

@kirkwaiblingerkirkwaiblinger added ASTPRs and Issues about the AST structure 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelsAug 27, 2025
@kirkwaiblingerkirkwaiblingerenabled auto-merge (squash)September 1, 2025 05:28
@kirkwaiblingerkirkwaiblinger merged commitee3efa7 intotypescript-eslint:mainSep 1, 2025
61 checks passed
@fiskerfisker deleted the revert-11493-revert-11232 branchSeptember 1, 2025 13:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeASTPRs and Issues about the AST structure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: forbid invalid keys inEnumMember

2 participants

@fisker@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp