Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions#11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedAug 15, 2025
edited
Loading

PR Checklist

Overview

Stacked on#11479

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 15, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6169380
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68db6069e1d81d000806f3f1
😎 Deploy Previewhttps://deploy-preview-11487--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 20 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 15, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit6169380

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 10sView ↗
nx run-many -t lint✅ Succeeded3m 24sView ↗
nx run-many -t typecheck✅ Succeeded2m 3sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-30 04:57:54 UTC

@codecovCodecov
Copy link

codecovbot commentedAug 15, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (db09a7d) to head (6169380).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11487   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51397    51392    -5       Branches     8484     8492    +8     =======================================- Hits        46738    46735    -3+ Misses       4646     4644    -2  Partials       13       13
FlagCoverage Δ
unittest90.93% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts98.40% <100.00%> (-0.03%)⬇️
...es/eslint-plugin/src/util/getOperatorPrecedence.ts62.17% <ø> (+0.74%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewAugust 15, 2025 18:59
@kirkwaiblingerkirkwaiblinger marked this pull request as draftAugust 15, 2025 18:59
@kirkwaiblingerkirkwaiblinger changed the titlefix(eslint-plugin): [no-floating-promises] remove excessive parentheses in suggestionsfix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestionsAug 15, 2025
@JoshuaKGoldberg
Copy link
Member

@kirkwaiblinger is this ready now?

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewSeptember 30, 2025 04:46
@kirkwaiblinger
Copy link
MemberAuthor

@kirkwaiblinger is this ready now?

@JoshuaKGoldberg Redid it since it was pretty stale! Should be ready now

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great! 🚀

kirkwaiblinger reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 30, 2025
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

kirkwaiblinger reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitd447248 intotypescript-eslint:mainOct 1, 2025
71 of 72 checks passed
@kirkwaiblingerkirkwaiblinger deleted the fix-excessive-parentheses branchOctober 1, 2025 14:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@ronamironamironami approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-floating-promises] adds extra parentheses to already-parenthesized expression
3 participants
@kirkwaiblinger@JoshuaKGoldberg@ronami

[8]ページ先頭

©2009-2025 Movatter.jp