Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): correct range of import assertion with trailing comma#11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Account for possibility of trailing comma in import assertion when converting TS AST to ESTree

Also fix up some tsconfig stuff that broke the ability to useexpectBabelToNotSupport in#11126 (seehttps://github.com/typescript-eslint/typescript-eslint/pull/11126/files#diff-3875bfe708efc111c8948e62750d6ccd5dfc7844ca223fa3dbcd7edd0a601259)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 14, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7a6f2f2
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/689f818cfd4cb10007a02c38
😎 Deploy Previewhttps://deploy-preview-11478--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 71 (🔴 down 21 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 14, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit7a6f2f2

CommandStatusDurationResult
nx run-many -t lint✅ Succeeded3m 20sView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded2sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded3sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
nx run generate-configs✅ Succeeded9sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-08-15 19:03:04 UTC

@codecovCodecov
Copy link

codecovbot commentedAug 14, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is0% with5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.87%. Comparing base (b2ee794) to head (7a6f2f2).
⚠️ Report is 2 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts0.00%5 Missing⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11478      +/-   ##==========================================- Coverage   90.87%   90.87%   -0.01%==========================================  Files         505      505                Lines       51117    51121       +4       Branches     8415     8415              ==========================================  Hits        46455    46455- Misses       4648     4652       +4  Partials       14       14
FlagCoverage Δ
unittest90.87% <0.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/convert.ts30.16% <0.00%> (-0.04%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblingerkirkwaiblinger marked this pull request as draftAugust 14, 2025 07:18
@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewAugust 15, 2025 18:59
@bradzacherbradzacher merged commit37d9ccc intotypescript-eslint:mainAug 16, 2025
62 of 63 checks passed
@kirkwaiblingerkirkwaiblinger deleted the import-attribute-comma branchAugust 16, 2025 04:13
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

+1 more reviewer

@fiskerfiskerfisker left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect "TSImportType#options" end when the option key-value contains trailing comma
3 participants
@kirkwaiblinger@fisker@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp