Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(scope-manager): exclude Program from DefinitionBase node types#11469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

dbarabashh
Copy link
Contributor

@dbarabashhdbarabashh commentedAug 8, 2025•
edited
Loading

Fix#11334

PR Checklist

Overview

This PR improves type safety in thescope-manager package by preventingTSESTree.Program nodes from being used as definition nodes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 8, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit382a149
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68b0b4fce94a83000803763e
😎 Deploy Previewhttps://deploy-preview-11469--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 77 (🔴 down 20 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 8, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit382a149

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 16sView ↗
nx run-many -t lint✅ Succeeded3m 13sView ↗
nx run-many -t typecheck✅ Succeeded2m 22sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded9sView ↗
nx run integration-tests:test✅ Succeeded6sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded9sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-08-28 20:11:12 UTC

@dbarabashh
Copy link
ContributorAuthor

I am not sure that the linter failed now exactly because of my changes, because locally this command was successful

@JoshuaKGoldberg
Copy link
Member

Try ayarn build first, then ayarn lint? It looks like the types are better informed because of this change (nice!), so lint rules are pointing out previously missed unnecessary?.s and the like.

@codecovCodecov
Copy link

codecovbot commentedAug 9, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (31a7336) to head (382a149).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11469      +/-   ##==========================================- Coverage   90.87%   90.87%   -0.01%==========================================  Files         505      505                Lines       51146    51143       -3       Branches     8424     8424              ==========================================- Hits        46480    46477       -3  Misses       4652     4652                Partials       14       14
FlagCoverage Δ
unittest90.87% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts100.00% <100.00%> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts96.19% <100.00%> (ø)
...ges/scope-manager/src/definition/DefinitionBase.ts100.00% <ø> (ø)
...src/definition/ImplicitGlobalVariableDefinition.ts100.00% <ø> (ø)
packages/scope-manager/src/referencer/Reference.ts93.44% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dbarabashh
Copy link
ContributorAuthor

@JoshuaKGoldberg thank you, done

@kirkwaiblinger
Copy link
Member

@dbarabashh Would you mind also auditing for uses ofnullThrows that can be removed? For example,

constblock=nullThrows(node.parent,NullThrowsReasons.MissingParent);

JoshuaKGoldberg and dbarabashh reacted with thumbs up emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1 to what Kirk said. I also think the new type is good enough that it should be moved to@typescript-eslint/types altogether. Thanks for starting this! 🙌

kirkwaiblinger reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelAug 27, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelAug 28, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤤 look at all those removed?~s andnullThrows()`s! Absolutely lovely. Thanks!

dbarabashh reacted with rocket emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 3, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉🎉

@JoshuaKGoldbergJoshuaKGoldberg merged commitc068a4f intotypescript-eslint:mainSep 3, 2025
65 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 10, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: DefinitionBase shouldn't allow its Node type to be TSESTree.Program
3 participants
@dbarabashh@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp