I haven't written an automated test for this, since... it's not super clear how without mocking the v8 stack trace API (which seems really yucky) or writing a full integration test (tedious).

But it's very easy to clone down the repo in#11429,yarn link, and observe the bug being fixed.

Maybe more comprehensive automated testing of thetsconfigRootDir can be a follow-on if we want to invest in that effort?

fix 11429

a296728

Copy link

Contributor

typescript-eslintbot commentedAug 6, 2025

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedAug 6, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`740b45d`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/689538158866c80007ba6bbb
😎 Deploy Preview	https://deploy-preview-11464--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 8 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

terribly

8537da4

kirkwaiblinger changed the title~~fix(typescript-eslint): handlefile:// urls in stack trace API~~fix(typescript-eslint): handlefile:// urls in stack trace when inferringtsconfigRootDir

Aug 6, 2025

Copy link

nx-cloudbot commentedAug 6, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit740b45d

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 19s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 12s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-08-07 23:40:19 UTC

Copy link

codecovbot commentedAug 6, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (88b063e) to head (740b45d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11464   +/-   ##=======================================  Coverage   90.88%   90.88%           =======================================  Files         505      505             Lines       51121    51125    +4       Branches     8413     8415    +2     =======================================+ Hits        46459    46463    +4  Misses       4648     4648             Partials       14       14

Flag	Coverage Δ
unittest	`90.88% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...pescript-eslint/src/getTSConfigRootDirFromStack.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.