This ensures that tsconfigRootDir must always be absolute if provided. Adds testing. Adjusts existing testing which used relative tsconfigRootDirs rather than absolute.

Handles normalization so that trailing path sep bug is also solved (test included)

kirkwaiblinger added2 commits

August 6, 2025 11:33

input validation

beccf4e

tweaks and such

c641467

Copy link

Contributor

typescript-eslintbot commentedAug 6, 2025

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedAug 6, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c20f200`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68a36c72c44fd80008af9dd7
😎 Deploy Preview	https://deploy-preview-11463--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 79 (🔴 down 15 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedAug 6, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc20f200

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 10s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 17s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 12s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	20s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	10s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-08-18 18:20:29 UTC

Copy link

codecovbot commentedAug 6, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is93.75000% with2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (60c3b26) to head (7451eb5).

⚠️Current head7451eb5 differs from pull request most recent headc20f200

Pleaseupload reports for the commitc20f200 to get more accurate results.

Files with missing lines	Patch %	Lines
...pt-estree/src/parseSettings/createParseSettings.ts	93.54%	2 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11463      +/-   ##==========================================+ Coverage   90.87%   90.88%   +0.01%==========================================  Files         505      505                Lines       51121    51142      +21       Branches     8415     8424       +9     ==========================================+ Hits        46455    46480      +25+ Misses       4652     4648       -4  Partials       14       14

Flag	Coverage Δ
unittest	`90.88% <93.75%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...ges/typescript-estree/src/create-program/shared.ts	`88.75% <100.00%> (+0.94%)`	⬆️
...pt-estree/src/parseSettings/createParseSettings.ts	`92.69% <93.54%> (+0.50%)`	⬆️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kirkwaiblinger mentioned this pull request

Aug 6, 2025

Bug: Can't find tsconfig.json withproject: true and imported config#11429

Closed

4 tasks

fixup

c3b9f4e

kirkwaiblinger force-pushed thetsconfig-root-beer branch fromd151ca5 toc3b9f4eCompare

August 6, 2025 22:45

kirkwaiblinger added5 commits

August 6, 2025 16:47

evolving any

8073167

windows

04366b0

Merge branch 'main' into tsconfig-root-beer

0ddaf39

tweaks

8338445

windows test

fa7ec73

kirkwaiblinger changed the title~~fix:tsconfigRootDir bugs~~fix: tightentsconfigRootDir validation

Aug 11, 2025

kirkwaiblinger added15 commits

August 11, 2025 10:47

absolutify

848e29a

fixup posix snapshots

ac410c8

maybe

aed165f

test

f9b4f2a

maybe now?

7b6d4ba

structured clone yay

961827c

fixup

ee3d2b9

test

e6ff7af

less

33a1401

again

eabd1be

wtf

e647ab0

ohhhhh - maybe this?

e9625a7

hoisting

2abe6b5

back in biz

cbbf433

yeah yeah yeah

a134944

kirkwaiblinger added8 commits

August 11, 2025 14:11

fun fun

e6b1b8c

typo

ff57b0d

revert print debugging

8277e00

cov

938bb9b

istanbul syntax

fdca74d

cov

2d4ad1f

lint, ugh

c2f4771

cov ignore comments dont really work with vitest

7451eb5

kirkwaiblinger marked this pull request as ready for review

August 11, 2025 22:27

bradzacher approved these changes

Aug 11, 2025

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

kirkwaiblinger commented

Aug 11, 2025

View reviewed changes

packages/typescript-estree/src/parseSettings/createParseSettings.ts

Comment on lines +72 to +73

		(process.platform==='win32'&&
		!/^[a-zA-Z]:/.test(userProvidedTsconfigRootDir))

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is tested but it doesn't get picked up in the coverage report, due to only being tested on windows. Tried to use anistanbul ignore comment, but vitest/esbuild/typescript has problems with coverage ignore comments due to comment stripping and I couldn't get it to work :(

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Aug 11, 2025

kirkwaiblinger changed the title~~fix: tightentsconfigRootDir validation~~feat: tightentsconfigRootDir validation

Aug 15, 2025

kirkwaiblingerenabled auto-merge (squash)

August 18, 2025 15:11

kirkwaiblinger added2 commits

August 18, 2025 09:11

Merge branch 'main' into tsconfig-root-beer

28aee27

Merge branch 'main' into tsconfig-root-beer

c20f200

kirkwaiblinger merged commit270fa59 intotypescript-eslint:main

Aug 18, 2025

59 of 61 checks passed

kirkwaiblinger deleted the tsconfig-root-beer branch

August 18, 2025 21:59

lvzhenbo mentioned this pull request

Aug 25, 2025

Bug: (Windows) Parsing error: inferred tsconfigRootDir should be a resolved absolute path, but received: "C:/Users/29422/Desktop/vue-project".#11530

Closed

4 tasks

github-actionsbot locked asresolvedand limited conversation to collaborators

Aug 26, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: tighten`tsconfigRootDir` validation#11463

feat: tighten`tsconfigRootDir` validation#11463

Uh oh!

Conversation

kirkwaiblinger commentedAug 6, 2025•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedAug 6, 2025

Uh oh!

netlifybot commentedAug 6, 2025•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedAug 6, 2025•
edited
Loading

Uh oh!

Uh oh!

codecovbot commentedAug 6, 2025•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblingerAug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

feat: tightentsconfigRootDir validation#11463

feat: tightentsconfigRootDir validation#11463

Uh oh!

Conversation

kirkwaiblinger commentedAug 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedAug 6, 2025

Uh oh!

netlifybot commentedAug 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedAug 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedAug 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblingerAug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: tighten`tsconfigRootDir` validation#11463

feat: tighten`tsconfigRootDir` validation#11463

kirkwaiblinger commentedAug 6, 2025•
edited
Loading

netlifybot commentedAug 6, 2025•
edited
Loading

nx-cloudbot commentedAug 6, 2025•
edited
Loading

codecovbot commentedAug 6, 2025•
edited
Loading