Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [consistent-type-exports] fix declaration shadowing#11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ntdiary
Copy link
Contributor

@ntdiaryntdiary commentedAug 5, 2025•
edited
Loading

PR Checklist

Overview

this PR will alsofix#10313.

The comment ongetSymbolFlags mentions a similar case:

/**     * Gets combined flags of a `symbol` and all alias targets it resolves to. `resolveAlias`     * is typically recursive over chains of aliases, but stops mid-chain if an alias is merged     * with another exported symbol, e.g.     * ```ts     * // a.ts     * export const a = 0;     * // b.ts     * export { a } from "./a";     * export type a = number;     * // c.ts     * import { a } from "./b";     * ```     * Calling `resolveAlias` on the `a` in c.ts would stop at the merged symbol exported     * from b.ts, even though there is still more alias to resolve. Consequently, if we were     * trying to determine if the `a` in c.ts has a value meaning, looking at the flags on     * the local symbol and on the symbol returned by `resolveAlias` is not enough.     *@returns SymbolFlags.All if `symbol` is an alias that ultimately resolves to `unknown`;     * combined flags of all alias targets otherwise.     */functiongetSymbolFlags(symbol:Symbol,excludeTypeOnlyMeanings?:boolean,excludeLocalMeanings?:boolean):SymbolFlags{

resolveAlias is typically recursive over chains of aliases, but stops mid-chain if an alias is merged with another exported symbol. So we need a loop to check whether the target has a value meaning.
There might be a more robust public API for these cases in TS in the future (possiblysymbolIsValue?), but considering compatibility and simplicity, I feel thewhile in this PR could be sufficient for our current needs.
Please feel free to let me know if you have any better ideas. 😄

💖

Xunnamius reacted with hooray emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 5, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0a88ead
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68b8f34d7b2ee5000899f187
😎 Deploy Previewhttps://deploy-preview-11457--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 81 (🔴 down 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit0a88ead

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 14sView ↗
nx run-many -t lint✅ Succeeded3m 11sView ↗
nx run-many -t typecheck✅ Succeeded2m 4sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded6sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-04 02:13:46 UTC

@codecovCodecov
Copy link

codecovbot commentedAug 5, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (f0e64eb) to head (0a88ead).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11457   +/-   ##=======================================  Coverage   90.90%   90.91%           =======================================  Files         505      505             Lines       51155    51153    -2       Branches     8424     8426    +2     =======================================+ Hits        46503    46506    +3+ Misses       4639     4634    -5  Partials       13       13
FlagCoverage Δ
unittest90.91% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...eslint-plugin/src/rules/consistent-type-exports.ts95.97% <100.00%> (+1.51%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntdiaryntdiary marked this pull request as ready for reviewAugust 5, 2025 14:18
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! 👌 very well done on the line reduction.

ntdiary reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 3, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitf77a31d intotypescript-eslint:mainSep 5, 2025
60 of 62 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 10, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [consistent-type-export] Declaration shadowing causes false positive Bug: [consistent-type-export] consider same-named term/types
2 participants
@ntdiary@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp