typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType#11432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfrommdm317:fix-11225

Sep 8, 2025

Merged

fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType#11432

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfrommdm317:fix-11225

Sep 8, 2025

+58 −0

Conversation

Copy link

Contributor

mdm317 commentedJul 29, 2025

PR Checklist

Addresses an existing open issue:fixesBug:prefer-return-this-type reports on return type unions containing the class when an actual return value might not bethis #11225
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Don't report an error when returning a union type that includes aclassType.

mdm317 added2 commits

July 30, 2025 00:09

fix: Add logic when returning a union type.

b3d8075

test: add test

602a349

Copy link

Contributor

typescript-eslintbot commentedJul 29, 2025

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 29, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9a559d3`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68bee3f9e09a6400085911d6
😎 Deploy Preview	https://deploy-preview-11432--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 75 (🔴 down 22 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJul 29, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit9a559d3

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 6s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	4s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 13s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	5s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-09-08 14:24:04 UTC

mdm317 changed the title~~fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType.~~fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType

Jul 29, 2025

Copy link

ContributorAuthor

mdm317 commentedJul 30, 2025

I think there's an issue with these two CI commands:
nx run ast-spec:test -- --coverage andnx run integration-tests:test

If not, please let me know.

mdm317 marked this pull request as ready for review

July 30, 2025 15:16

Copy link

Member

kirkwaiblinger commentedJul 31, 2025

I think there's an issue with these two CI commands:nx run ast-spec:test -- --coverage andnx run integration-tests:test
If not, please let me know.

Yeah, filed#11436,#11437,#11438

Copy link

Member

JoshuaKGoldberg commentedSep 3, 2025

main is up-to-date now; merging it in should fix the CI issues. I'll go ahead and do that now.

Merge branch 'main' into fix-11225

306fda0

JoshuaKGoldberg previously approved these changes

Sep 3, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice and clean, thank you!

Just one note onhiddens in tests - we can always clean this up before release.

packages/eslint-plugin/tests/rules/prefer-return-this-type.test.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Sep 3, 2025

Copy link

codecovbot commentedSep 3, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (42cf79e) to head (9a559d3).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11432      +/-   ##==========================================+ Coverage   90.90%   90.92%   +0.01%==========================================  Files         505      505                Lines       51125    51180      +55       Branches     8421     8432      +11     ==========================================+ Hits        46473    46533      +60+ Misses       4639     4634       -5  Partials       13       13

Flag	Coverage Δ
unittest	`90.92% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...eslint-plugin/src/rules/prefer-return-this-type.ts	`98.60% <100.00%> (+0.08%)`	⬆️

... and13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Math.random()

9a559d3

JoshuaKGoldberg dismissed theirstale review via9a559d3

September 8, 2025 14:11

JoshuaKGoldberg merged commitbd8ed8d intotypescript-eslint:main

Sep 8, 2025

62 checks passed

ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull request

Sep 10, 2025

Porttypescript-eslint/typescript-eslint#11432

15123b5

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 10, 2025

Update typescript-eslint monorepo to v8.43.0

ea14311

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

fossabotbot mentioned this pull request

Sep 29, 2025

Bump @typescript-eslint/eslint-plugin from 8.42.0 to 8.44.1fossas/fossa-action#210

Merged

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

3 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType#11432

fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType#11432