Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-floating-promises] allowForKnownSafeCalls now supports function names (fixes #11423)#11430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfrom976520:main
Sep 8, 2025

Conversation

976520
Copy link
Contributor

@976520976520 commentedJul 28, 2025•
edited
Loading

PR Checklist

Overview

The allowForKnownSafeCalls option was only checking type-based matching using typeMatchesSomeSpecifier and completely ignoring value-based (function name) matching. This caused configurations like["randomAsyncFunction"] to be ignored, even though the documentation indicated they should work 💖

  • f4d5dae

    • Added specific test cases for string-based function name matching

  • 8c1cc90

    • First check value-based matching using valueMatchesSomeSpecifier for function names
    • Fall back to type-based matching using typeMatchesSomeSpecifier for type specifications
    • Added the missing import for valueMatchesSomeSpecifier

  • af92aea

    • Updated documentation and test snapshots
    • Removed unnecessary skipValidation from example

gunzy83 reacted with thumbs up emoji
… optionAdd test cases to verify that function name-based allowForKnownSafeCallsconfiguration works correctly for locally defined async functions.
…tion names (typescript-eslint#11423)The allowForKnownSafeCalls option was only checking type-based matchingand not value-based matching, causing function name specifications like["myAsyncFunction"] to be ignored. Now properly checks both value andtype matching using valueMatchesSomeSpecifier.
- Remove skipValidation from allowForKnownSafeCalls example- Update test snapshots after fixing function name matching
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@976520!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 28, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitff2e5cd
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68bc26b65757c30008e666c4
😎 Deploy Previewhttps://deploy-preview-11430--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 28, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitff2e5cd

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 6sView ↗
nx run-many -t lint✅ Succeeded3m 7sView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-06 12:30:22 UTC

@codecovCodecov
Copy link

codecovbot commentedJul 28, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (fee2bc6) to head (ff2e5cd).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11430      +/-   ##==========================================+ Coverage   90.87%   90.91%   +0.03%==========================================  Files         505      505                Lines       51117    51163      +46       Branches     8415     8428      +13     ==========================================+ Hits        46455    46516      +61+ Misses       4648     4634      -14+ Partials       14       13       -1
FlagCoverage Δ
unittest90.91% <100.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts98.42% <100.00%> (+0.04%)⬆️

... and16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 3, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Just one suggestion for a naming update, nothing in core logic or tests. Happy to just apply this change before our next release. Cheers! ❤️

gunzy83 reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 3, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit5d15bc2 intotypescript-eslint:mainSep 8, 2025
62 checks passed
ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull requestSep 10, 2025
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestSep 10, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 || npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-floating-promises] allowForKnownSafeCalls doesn't select named variable function expressions with string matchers
2 participants
@976520@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp